Skip to content

Make test actorsystem actor id globally unique #1087 #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2024
Merged

Make test actorsystem actor id globally unique #1087 #1081

merged 1 commit into from
Jan 17, 2024

Conversation

robdrynkin
Copy link
Collaborator

@robdrynkin robdrynkin commented Jan 17, 2024 •
edited
Loading

Changelog entry

For now in prod actor system actor ids generating globally unique, but in test actor system after node restart old actor ids of this will be reused. This commit makes allocation of actor ids in test actor system globally unique
...

Changelog category

  • Bugfix

Additional information

...

@robdrynkin robdrynkin changed the title Make test actorsystem actor id globaly unique Make test actorsystem actor id globally unique Jan 17, 2024
@robdrynkin robdrynkin force-pushed the fix_test_actorsys_alloc_actor_id branch from 7b97cbb to 704fbd7 Compare January 17, 2024 10:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2024 •
edited
Loading

⚪ 2024-01-17 10:20:41 UTC Pre-commit check for 704fbd7 has started.
⚪ 2024-01-17 10:20:44 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-01-17 10:23:35 UTC Build failed. see the build logs.
⚪ 2024-01-17 10:23:48 UTC Tests are running...
🔴 2024-01-17 12:05:07 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59810 50572 0 5 9222 11

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2024 •
edited
Loading

⚪ 2024-01-17 10:21:07 UTC Pre-commit check for 704fbd7 has started.
⚪ 2024-01-17 10:21:08 UTC Build linux-x86_64-release-asan is running...
🔴 2024-01-17 10:24:19 UTC Build failed. see the build logs.
⚪ 2024-01-17 10:24:28 UTC Tests are running...
🔴 2024-01-17 12:04:59 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15763 15674 0 19 54 16

@robdrynkin robdrynkin marked this pull request as ready for review January 17, 2024 10:52
@robdrynkin robdrynkin requested a review from alexvru January 17, 2024 10:52
@robdrynkin robdrynkin changed the title Make test actorsystem actor id globally unique Make test actorsystem actor id globally unique #1087 Jan 17, 2024
@robdrynkin robdrynkin linked an issue Jan 17, 2024 that may be closed by this pull request
Make ActorId unique in test actor system #1087
Closed
@robdrynkin robdrynkin merged commit 4737601 into ydb-platform:main Jan 17, 2024
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 24, 2024
Merged
@FloatingCrowbar FloatingCrowbar mentioned this pull request Jan 24, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 25, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 25, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Jan 25, 2024
Merged
This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 29, 2024
Merged
@shnikd shnikd mentioned this pull request Jan 29, 2024
Merged
This was referenced Jan 29, 2024
Merged
Merged
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvru alexvru alexvru approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ActorId unique in test actor system
3 participants
@robdrynkin @alexvru @blinkov