Rate Limiter metrics have been added in control plane proxy #10652

dorooleg · 2024-10-21T09:54:39Z

Changelog entry

...

Changelog category

Not for changelog (changelog entry is not required)

Additional information

...

github-actions · 2024-10-21T09:55:57Z

⚪ 2024-10-21 09:55:56 UTC Pre-commit check linux-x86_64-release-asan for a4c067b has started.
⚪ 2024-10-21 09:56:05 UTC Artifacts will be uploaded here
⚪ 2024-10-21 09:59:01 UTC ya make is running...
🟡 2024-10-21 11:27:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10158	9851	0	97	88	122

🟢 2024-10-21 11:28:26 UTC Build successful.
🟢 2024-10-21 11:28:59 UTC ydbd size 5.7 GiB changed* by +17.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `7f4d37b`	merge: `a4c067b`	diff	diff %
ydbd size	6 108 702 688 Bytes	6 108 720 128 Bytes	+17.0 KiB	+0.000%
ydbd stripped size	1 522 711 760 Bytes	1 522 715 984 Bytes	+4.1 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-21T09:58:11Z

⚪ 2024-10-21 09:58:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for a4c067b has started.
⚪ 2024-10-21 09:58:21 UTC Artifacts will be uploaded here
⚪ 2024-10-21 10:01:23 UTC ya make is running...
🟡 2024-10-21 10:56:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
39742	34131	0	13	5502	96

⚪ 2024-10-21 10:59:38 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-21 11:11:05 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
108 (only retried tests)	16	0	0	0	92

🟢 2024-10-21 11:11:13 UTC Build successful.
🟢 2024-10-21 11:11:31 UTC ydbd size 2.8 GiB changed* by +7.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `7f4d37b`	merge: `a4c067b`	diff	diff %
ydbd size	3 015 313 344 Bytes	3 015 321 184 Bytes	+7.7 KiB	+0.000%
ydbd stripped size	477 978 264 Bytes	477 979 672 Bytes	+1.4 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ydb/core/fq/libs/control_plane_proxy/actors/request_actor.h

uzhastik · 2024-10-28T12:52:12Z

ydb/core/fq/libs/control_plane_proxy/actors/request_actor.h

                                            TEvControlPlaneProxy::TEvCreateQueryResponse>;
-    using TBaseRequestActor::TBaseRequestActor;
+
+        explicit TCreateQueryRequestActor(typename TEvControlPlaneProxy::TEvCreateQueryRequest::TPtr requestProxy,


explicit бесполезен тут

Он запрещает записи вида:

TCreateQueryRequestActor a = {requestProxy, config, ...};

Позволяет код держать в более строгом виде. Ослабляем требование?

я бы не боролся с таким синтаксисом. чаще всего проблема все же с неявным преобразованием для одного аргумента

TCreateQueryRequestActor a = requestProxy;

ydb/core/fq/libs/control_plane_proxy/actors/request_actor.h

github-actions · 2024-10-29T16:25:54Z

⚪ 2024-10-29 16:25:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 775007e has started.
⚪ 2024-10-29 16:26:04 UTC Artifacts will be uploaded here
⚪ 2024-10-29 16:29:09 UTC ya make is running...
🟡 2024-10-29 17:26:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
39820	34182	0	2	5539	97

⚪ 2024-10-29 17:30:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-29 17:41:54 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
98 (only retried tests)	6	0	0	0	92

🟢 2024-10-29 17:42:00 UTC Build successful.
🟢 2024-10-29 17:42:19 UTC ydbd size 2.8 GiB changed* by +7.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `b644208`	merge: `775007e`	diff	diff %
ydbd size	3 038 149 360 Bytes	3 038 157 160 Bytes	+7.6 KiB	+0.000%
ydbd stripped size	481 241 048 Bytes	481 242 392 Bytes	+1.3 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-29T16:26:18Z

⚪ 2024-10-29 16:26:18 UTC Pre-commit check linux-x86_64-release-asan for 775007e has started.
⚪ 2024-10-29 16:26:29 UTC Artifacts will be uploaded here
⚪ 2024-10-29 16:29:30 UTC ya make is running...
🟡 2024-10-29 17:37:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9082	9011	0	30	8	33

🟢 2024-10-29 17:38:01 UTC Build successful.
🟢 2024-10-29 17:38:31 UTC ydbd size 5.7 GiB changed* by +17.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `b644208`	merge: `775007e`	diff	diff %
ydbd size	6 147 758 656 Bytes	6 147 776 112 Bytes	+17.0 KiB	+0.000%
ydbd stripped size	1 534 157 168 Bytes	1 534 161 392 Bytes	+4.1 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-11-01T14:44:51Z

⚪ 2024-11-01 14:44:51 UTC Pre-commit check linux-x86_64-release-asan for 524efca has started.
⚪ 2024-11-01 14:45:01 UTC Artifacts will be uploaded here
⚪ 2024-11-01 14:47:59 UTC ya make is running...
🟡 2024-11-01 15:55:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9090	9015	0	30	10	35

🟢 2024-11-01 15:56:11 UTC Build successful.
🟢 2024-11-01 15:56:42 UTC ydbd size 5.7 GiB changed* by +17.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `509064d`	merge: `524efca`	diff	diff %
ydbd size	6 149 523 352 Bytes	6 149 540 808 Bytes	+17.0 KiB	+0.000%
ydbd stripped size	1 534 949 648 Bytes	1 534 953 872 Bytes	+4.1 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-11-01T14:44:51Z

⚪ 2024-11-01 14:44:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 524efca has started.
⚪ 2024-11-01 14:45:02 UTC Artifacts will be uploaded here
⚪ 2024-11-01 14:48:10 UTC ya make is running...
🟡 2024-11-01 15:44:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
39918	34267	0	4	5549	98

⚪ 2024-11-01 15:48:13 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-01 15:59:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
100 (only retried tests)	7	0	1	0	92

⚪ 2024-11-01 15:59:51 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-11-01 16:11:27 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
93 (only retried tests)	0	0	1	0	92

🟢 2024-11-01 16:11:34 UTC Build successful.
🟢 2024-11-01 16:11:57 UTC ydbd size 2.8 GiB changed* by +7.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `509064d`	merge: `524efca`	diff	diff %
ydbd size	3 039 067 160 Bytes	3 039 074 960 Bytes	+7.6 KiB	+0.000%
ydbd stripped size	481 438 296 Bytes	481 439 640 Bytes	+1.3 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-11-01T16:21:16Z

⚪ 2024-11-01 16:21:15 UTC Pre-commit check linux-x86_64-release-asan for 524efca has started.
⚪ 2024-11-01 16:22:04 UTC Artifacts will be uploaded here
⚪ 2024-11-01 16:25:34 UTC ya make is running...
🟡 2024-11-01 17:29:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9090	9018	0	30	9	33

🟢 2024-11-01 17:30:11 UTC Build successful.
🟢 2024-11-01 17:30:41 UTC ydbd size 5.7 GiB changed* by +17.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `509064d`	merge: `524efca`	diff	diff %
ydbd size	6 149 523 352 Bytes	6 149 540 808 Bytes	+17.0 KiB	+0.000%
ydbd stripped size	1 534 949 648 Bytes	1 534 953 872 Bytes	+4.1 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-11-01T16:23:05Z

⚪ 2024-11-01 16:23:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 524efca has started.
⚪ 2024-11-01 16:23:48 UTC Artifacts will be uploaded here
⚪ 2024-11-01 16:27:27 UTC ya make is running...
🟡 2024-11-01 17:29:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
39916	34268	0	4	5550	94

⚪ 2024-11-01 17:32:28 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-01 17:44:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
99 (only retried tests)	6	0	1	0	92

⚪ 2024-11-01 17:44:19 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-11-01 17:56:12 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
93 (only retried tests)	0	0	1	0	92

🟢 2024-11-01 17:56:19 UTC Build successful.
🟢 2024-11-01 17:56:40 UTC ydbd size 2.8 GiB changed* by +7.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `509064d`	merge: `524efca`	diff	diff %
ydbd size	3 039 067 160 Bytes	3 039 074 960 Bytes	+7.6 KiB	+0.000%
ydbd stripped size	481 438 296 Bytes	481 439 640 Bytes	+1.3 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-19T09:50:57Z

⚪ 2024-12-19 09:50:56 UTC Pre-commit check linux-x86_64-release-asan for 3db2a7e has started.
⚪ 2024-12-19 09:51:32 UTC Artifacts will be uploaded here
⚪ 2024-12-19 09:55:09 UTC ya make is running...
🟡 2024-12-19 11:00:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11926	11830	0	41	10	45

🟢 2024-12-19 11:01:38 UTC Build successful.
🟢 2024-12-19 11:02:05 UTC ydbd size 3.6 GiB changed* by +10.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `5244b5d`	merge: `3db2a7e`	diff	diff %
ydbd size	3 896 411 120 Bytes	3 896 421 520 Bytes	+10.2 KiB	+0.000%
ydbd stripped size	1 364 406 704 Bytes	1 364 409 456 Bytes	+2.7 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-19T09:52:11Z

⚪ 2024-12-19 09:52:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3db2a7e has started.
⚪ 2024-12-19 09:52:14 UTC Artifacts will be uploaded here
⚪ 2024-12-19 09:55:08 UTC ya make is running...
🟡 2024-12-19 10:50:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
28594	25644	0	7	2830	113

⚪ 2024-12-19 10:53:46 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-19 11:05:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
166 (only retried tests)	55	0	2	0	109

⚪ 2024-12-19 11:05:28 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-12-19 11:16:40 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
155 (only retried tests)	46	0	0	0	109

🟢 2024-12-19 11:16:47 UTC Build successful.
🟢 2024-12-19 11:17:10 UTC ydbd size 2.1 GiB changed* by +10.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `5244b5d`	merge: `3db2a7e`	diff	diff %
ydbd size	2 254 802 928 Bytes	2 254 814 120 Bytes	+10.9 KiB	+0.000%
ydbd stripped size	483 250 224 Bytes	483 255 728 Bytes	+5.4 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

…form#10652)

dorooleg requested a review from a team as a code owner October 21, 2024 09:54

github-actions bot added the not-for-changelog label Oct 21, 2024

uzhastik reviewed Oct 28, 2024

View reviewed changes

ydb/core/fq/libs/control_plane_proxy/actors/request_actor.h Show resolved Hide resolved

uzhastik reviewed Oct 28, 2024

View reviewed changes

ydb/core/fq/libs/control_plane_proxy/actors/request_actor.h Show resolved Hide resolved

dorooleg added 2 commits October 29, 2024 16:13

Rate Limiter metrics have been added in control plane proxy

a48a785

comment about RateLimiterCreationInProgress has been added

98eeb55

dorooleg force-pushed the cpp_rate_limiter_metrics branch from f3e21f8 to 98eeb55 Compare October 29, 2024 16:22

get rid of the explicit keyword

c8d5c60

dorooleg added the rebase-and-check Rebase PR with the current base branch and check label Nov 1, 2024

github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Nov 1, 2024

uzhastik approved these changes Nov 1, 2024

View reviewed changes

dorooleg added the rebase-and-check Rebase PR with the current base branch and check label Dec 19, 2024

github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Dec 19, 2024

dorooleg merged commit d30aab1 into ydb-platform:main Dec 20, 2024
16 of 18 checks passed

dorooleg deleted the cpp_rate_limiter_metrics branch December 20, 2024 12:48

dorooleg added a commit to dorooleg/ydb that referenced this pull request Dec 20, 2024

Rate Limiter metrics have been added in control plane proxy (ydb-plat…

8bba5d6

…form#10652)

GrigoriyPA mentioned this pull request Dec 25, 2024

Fixed empty error from CMS create tenant request #12977

Merged

Rate Limiter metrics have been added in control plane proxy #10652

Rate Limiter metrics have been added in control plane proxy #10652

Uh oh!

Conversation

dorooleg commented Oct 21, 2024

Changelog entry

Changelog category

Additional information

Uh oh!

github-actions bot commented Oct 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

uzhastik Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

dorooleg Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

uzhastik Nov 1, 2024

Choose a reason for hiding this comment

Uh oh!

dorooleg Nov 1, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 29, 2024 •

edited

Loading

github-actions bot commented Oct 29, 2024 •

edited

Loading

github-actions bot commented Nov 1, 2024 •

edited

Loading

github-actions bot commented Nov 1, 2024 •

edited

Loading

github-actions bot commented Nov 1, 2024 •

edited

Loading

github-actions bot commented Nov 1, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading