Skip to content

delete nodes from local db every time we delete them from memory #10051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

vporyadke
Copy link
Collaborator

Changelog entry

fix a bug that could lead to nodes being down when reusing node ids

Changelog category

  • Bugfix

Additional information

...

@github-actions github-actions bot added the bugfix label Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 14:02:29 UTC Pre-commit check linux-x86_64-release-asan for 52e9dd6 has started.
2024-10-03 14:02:44 UTC Artifacts will be uploaded here
2024-10-03 14:05:34 UTC ya make is running...
🟡 2024-10-03 15:29:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10282 9934 0 43 263 42

🟢 2024-10-03 15:30:25 UTC Build successful.
🟡 2024-10-03 15:30:56 UTC ydbd size 5.7 GiB changed* by +482.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: fc93096 merge: 52e9dd6 diff diff %
ydbd size 6 086 052 408 Bytes 6 086 546 304 Bytes +482.3 KiB +0.008%
ydbd stripped size 1 520 518 448 Bytes 1 520 543 920 Bytes +24.9 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 14:03:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 52e9dd6 has started.
2024-10-03 14:03:45 UTC Artifacts will be uploaded here
2024-10-03 14:06:42 UTC ya make is running...
🟡 2024-10-03 14:53:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15237 13757 0 3 1377 100

2024-10-03 14:54:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-03 15:06:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 6 0 1 0 94

2024-10-03 15:06:30 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-03 15:17:52 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
95 (only retried tests) 3 0 1 0 91

🟢 2024-10-03 15:18:00 UTC Build successful.
🟡 2024-10-03 15:18:22 UTC ydbd size 2.8 GiB changed* by +240.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 82f8fc2 merge: 52e9dd6 diff diff %
ydbd size 3 001 749 640 Bytes 3 001 995 464 Bytes +240.1 KiB +0.008%
ydbd stripped size 477 341 432 Bytes 477 343 672 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 16:00:36 UTC Pre-commit check linux-x86_64-release-asan for e4b31de has started.
2024-10-03 16:00:40 UTC Artifacts will be uploaded here
2024-10-03 16:03:29 UTC ya make is running...
🟡 2024-10-03 17:27:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10311 9914 0 73 286 38

🟢 2024-10-03 17:28:21 UTC Build successful.
🟡 2024-10-03 17:28:53 UTC ydbd size 5.7 GiB changed* by +509.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1a8906f merge: e4b31de diff diff %
ydbd size 6 086 042 904 Bytes 6 086 565 048 Bytes +509.9 KiB +0.009%
ydbd stripped size 1 520 515 952 Bytes 1 520 546 992 Bytes +30.3 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 16:00:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for e4b31de has started.
2024-10-03 16:00:46 UTC Artifacts will be uploaded here
2024-10-03 16:03:38 UTC ya make is running...
🟡 2024-10-03 16:56:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15249 13770 0 4 1377 98

2024-10-03 16:57:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-03 17:09:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
100 (only retried tests) 6 0 1 0 93

2024-10-03 17:09:19 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-03 17:20:41 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
94 (only retried tests) 0 0 1 0 93

🟢 2024-10-03 17:20:47 UTC Build successful.
🟡 2024-10-03 17:21:09 UTC ydbd size 2.8 GiB changed* by +246.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1a8906f merge: e4b31de diff diff %
ydbd size 3 001 749 816 Bytes 3 002 002 504 Bytes +246.8 KiB +0.008%
ydbd stripped size 477 341 368 Bytes 477 344 824 Bytes +3.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 22:16:11 UTC Pre-commit check linux-x86_64-release-asan for a90443e has started.
2024-10-03 22:16:22 UTC Artifacts will be uploaded here
2024-10-03 22:19:24 UTC ya make is running...
🟡 2024-10-03 23:48:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10313 10064 0 74 68 107

🟢 2024-10-03 23:49:09 UTC Build successful.
🟡 2024-10-03 23:49:42 UTC ydbd size 5.7 GiB changed* by +493.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 595af5f merge: a90443e diff diff %
ydbd size 6 086 289 376 Bytes 6 086 794 216 Bytes +493.0 KiB +0.008%
ydbd stripped size 1 520 590 960 Bytes 1 520 614 768 Bytes +23.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 22:18:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for a90443e has started.
2024-10-03 22:18:55 UTC Artifacts will be uploaded here
2024-10-03 22:21:50 UTC ya make is running...
🟡 2024-10-03 23:08:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15249 13769 0 2 1378 100

2024-10-03 23:09:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-03 23:21:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 7 0 1 0 93

2024-10-03 23:21:51 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-03 23:33:06 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
94 (only retried tests) 1 0 1 0 92

🟢 2024-10-03 23:33:12 UTC Build successful.
🟡 2024-10-03 23:33:34 UTC ydbd size 2.8 GiB changed* by +241.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 595af5f merge: a90443e diff diff %
ydbd size 3 001 837 456 Bytes 3 002 085 152 Bytes +241.9 KiB +0.008%
ydbd stripped size 477 361 080 Bytes 477 363 640 Bytes +2.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 7, 2024

2024-10-07 03:19:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 697e4a5 has started.
2024-10-07 03:20:10 UTC Artifacts will be uploaded here
2024-10-07 03:23:05 UTC ya make is running...
🟡 2024-10-07 04:11:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15275 13732 0 2 1442 99

2024-10-07 04:12:21 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-07 04:23:47 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
162 (only retried tests) 69 0 0 0 93

🟢 2024-10-07 04:23:54 UTC Build successful.
🟡 2024-10-07 04:24:15 UTC ydbd size 2.8 GiB changed* by +245.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8b1b84a merge: 697e4a5 diff diff %
ydbd size 3 003 016 624 Bytes 3 003 267 616 Bytes +245.1 KiB +0.008%
ydbd stripped size 477 530 296 Bytes 477 536 888 Bytes +6.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 7, 2024

2024-10-07 03:22:36 UTC Pre-commit check linux-x86_64-release-asan for 697e4a5 has started.
2024-10-07 03:22:45 UTC Artifacts will be uploaded here
2024-10-07 03:25:35 UTC ya make is running...
🟡 2024-10-07 04:52:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10337 10083 0 83 65 106

🟢 2024-10-07 04:53:17 UTC Build successful.
🟡 2024-10-07 04:53:49 UTC ydbd size 5.7 GiB changed* by +488.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8b1b84a merge: 697e4a5 diff diff %
ydbd size 6 085 911 336 Bytes 6 086 411 016 Bytes +488.0 KiB +0.008%
ydbd stripped size 1 520 789 424 Bytes 1 520 812 976 Bytes +23.0 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vporyadke vporyadke requested review from ijon and adameat October 7, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants