Skip to content

always delete nodes persistently in hive #11272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

vporyadke
Copy link
Collaborator

Changelog entry

fix a bug that could lead to nodes being down when reusing node ids

Changelog category

  • Bugfix

Additional information

Backport of #10051

@vporyadke vporyadke requested a review from a team as a code owner November 5, 2024 11:19
Copy link

github-actions bot commented Nov 5, 2024

2024-11-05 11:21:27 UTC Pre-commit check for 0c7b1c4 has started.
2024-11-05 11:24:08 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-11-05 12:05:59 UTC Build successful.
2024-11-05 12:06:16 UTC Tests are running...
🔴 2024-11-05 13:31:36 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14600 13243 0 14 1303 40

🟡 2024-11-05 13:32:26 UTC ydbd size 8.2 GiB changed* by +982.0 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 23208c8 merge: 0c7b1c4 diff diff %
ydbd size 8 856 933 528 Bytes 8 857 939 144 Bytes +982.0 KiB +0.011%
ydbd stripped size 483 655 080 Bytes 483 657 704 Bytes +2.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 5, 2024

2024-11-05 11:22:20 UTC Pre-commit check for 0c7b1c4 has started.
2024-11-05 11:24:58 UTC Build linux-x86_64-release-asan is running...
🟢 2024-11-05 11:49:41 UTC Build successful.
2024-11-05 11:49:56 UTC Tests are running...
🔴 2024-11-05 13:54:31 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10303 10209 0 24 25 45

🟡 2024-11-05 13:55:15 UTC ydbd size 5.6 GiB changed* by +496.2 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 23208c8 merge: 0c7b1c4 diff diff %
ydbd size 5 990 481 528 Bytes 5 990 989 632 Bytes +496.2 KiB +0.008%
ydbd stripped size 1 501 498 240 Bytes 1 501 526 080 Bytes +27.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 5, 2024

2024-11-05 11:24:07 UTC Pre-commit check for 0c7b1c4 has started.
2024-11-05 11:26:42 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-11-05 11:34:21 UTC Build successful.

@vporyadke vporyadke merged commit 6d047a4 into ydb-platform:stable-24-3 Nov 5, 2024
8 of 12 checks passed
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants