Skip to content

Conversation

@kobzonega
Copy link
Contributor

@kobzonega kobzonega commented Jan 23, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Additional label gets into the StatefulSet selector. It prevents you from changing labels, which were set by default. As a result Storage does not allow you to edit .spec.additionalLabels.

The StatefulSet selector is an exclusively internal thing that user should not change after creation.

Issue Number: YDBOPS-7162

What is the new behavior?

  • Add special label ydb.tech/statefulset-name to podTemplate labels
  • Use label ydb.tech/statefulset-name as selectorLabels for Statefulset in new Storage/Database objects
  • Prevent to edit selectorLabels for existing StatefulSet

Other information

@kobzonega kobzonega changed the title Immutable statefulSet selectorLabels with label "ydb.tech/statefulset-name" YDBOPS-7162 Immutable statefulSet selectorLabels with label "ydb.tech/statefulset-name" Jan 23, 2024
@kobzonega kobzonega requested a review from artgromov January 23, 2024 09:38
@kobzonega kobzonega self-assigned this Jan 23, 2024
@kobzonega kobzonega changed the title YDBOPS-7162 Immutable statefulSet selectorLabels with label "ydb.tech/statefulset-name" Immutable statefulSet selectorLabels with label "ydb.tech/statefulset-name" Jan 24, 2024
@kobzonega kobzonega requested review from Jorres and bma13 March 4, 2024 15:10
@kobzonega kobzonega changed the title Immutable statefulSet selectorLabels with label "ydb.tech/statefulset-name" YDBOPS-7162 Immutable statefulSet selectorLabels with label "ydb.tech/statefulset-name" May 13, 2024
@kobzonega kobzonega merged commit 36ee6cf into ydb-platform:master Jun 26, 2024
kobzonega added a commit to kobzonega/ydb-kubernetes-operator that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants