Add console.warn to process.stdin catch block #2838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestander
reviewed
Mar 10, 2017
| @@ -120,6 +120,7 @@ export default class BaseReporter { | |||
| try { | |||
| standardInput = process.stdin; | |||
There was a problem hiding this comment.
could you please add a text comment why we do the trick?
Going forward this file may be refactored multiple times and we would loose the original reason for try/catch.
There was a problem hiding this comment.
No problem. This is done.
bestander
requested changes
Mar 10, 2017
scottaddie
force-pushed
the
display_exception_message
branch
from
a15fa80 to
b26f557
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per @Daniel15's suggestion, this PR adds a
console.warnstatement to thecatchblock introduced in PR #2837.Test plan
I ran the following commands to ensure that my changes didn't introduce any problems:
yarn run buildyarn run lintyarn run test