gracefully handle process.stdin exceptions #2837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel15
reviewed
Mar 5, 2017
| try { | ||
| standardInput = process.stdin; | ||
| } catch (e) { | ||
| delete process.stdin; |
There was a problem hiding this comment.
Perhaps this should console.warn(e.message)?
|
Looks good to me, thanks! If this fix is okay for Angular-cli, it's probably fine for Yarn too 😛 |
This was referenced Mar 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Several users of Visual Studio 2015 & 2017's NPM Task Runner extension have reported problems on Windows 7 with regard to running Yarn commands inside the IDE's Task Runner Explorer window. Interestingly enough, this doesn't appear to be an issue on Windows 10.
A fix for this problem was attempted here. The Angular CLI project also encountered the same problem, and it was fixed here.
This PR takes a very similar approach as that taken by the Angular CLI team. The PR also doesn't specifically test for the "win32" platform, as who knows what other platforms are really impacted by this.
Test plan
I ran the following commands to ensure that my changes didn't introduce any problems:
yarn run buildyarn run lintyarn run test