Skip to content

feat(compat): add vue-cli-plugin-vuetify and @vuetify/cli-plugin-utils to extensions #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

paul-soporan
Copy link
Member

@paul-soporan paul-soporan commented Jan 28, 2020

What's the problem this PR addresses?
vue-cli-plugin-vuetify depends on semver, but doesn't declare it as a dependency, which causes Yarn 2 PnP to throw Error: A package is trying to access another package without the second one being listed as a dependency of the first one when used inside a project.
@vuetify/cli-plugin-utils has the same issue.


How did you fix it?
This PR adds semver as a dependency to vue-cli-plugin-vuetify, as well as to @vuetify/cli-plugin-utils in plugin-compat's extensions.
I've also created a PR at vuetifyjs/vue-cli-plugins#155.

@merceyz
Copy link
Member

merceyz commented Jan 28, 2020

@milesj
Copy link

milesj commented Jan 28, 2020

@paul-soporan Sounds like those packages need to add semver to their dependency list. Updating berry seems like the wrong approach.

@paul-soporan
Copy link
Member Author

paul-soporan commented Jan 28, 2020

@merceyz, Thank you, I'll look into it tommorow.
@milesj, I'm sorry, but if I understand #733 correctly, isn't that the point of the built-in package extensions in the compat-plugin?
Edit: #733, not 773

@milesj
Copy link

milesj commented Jan 28, 2020

IMO, the first course of action would be to patch the upstream library. If that fails, then patch Yarn.

@arcanis
Copy link
Member

arcanis commented Jan 28, 2020

It's fine (and recommended, even) to open the PR here so that we can at least keep track of them. Otherwise it's clear people will just forget about it, and if the upstream repository is in low maintenance it'll take us time to notice it.

In this case I'll wait a few days and merge. Thanks @paul-soporan!

@paul-soporan
Copy link
Member Author

vuetifyjs/vue-cli-plugins#155 got merged, so I can close this PR. As a suggestion, I think that there could be a special pinned issue for extensions in plugin-compat, so that people can keep track of them more easily.

@paul-soporan paul-soporan deleted the feat/compat/vuetify-cli-plugins branch January 31, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants