Skip to content
This repository was archived by the owner on May 8, 2025. It is now read-only.

fix(dependencies): add undeclared dependencies #155

Merged
merged 3 commits into from
Jan 29, 2020
Merged

fix(dependencies): add undeclared dependencies #155

merged 3 commits into from
Jan 29, 2020

Conversation

paul-soporan
Copy link
Contributor

vue-cli-plugin-vuetify depends on semver, but doesn't declare it as a dependency, which causes Yarn 2 PnP to throw Error: A package is trying to access another package without the second one being listed as a dependency of the first one when used inside a project.

This PR adds semver as a dependency to vue-cli-plugin-vuetify, as well as to @vuetify/cli-plugin-utils (since I've noticed it has the same issue).

This PR preserves the version of semver (^6.3.0) that is declared as a devDependency in the root package.json(I didn't remove it because I'm not sure if it is used anywhere else).

@DRoet
Copy link
Contributor

DRoet commented Jan 28, 2020

nice work, I think this also needs the sass-loader (optional peer-deps) and vuetify-loader (not sure if optional) as dependencies

@paul-soporan
Copy link
Contributor Author

Done.
sass-loader has been added as an optional peer dependency to @vuetify/cli-plugin-utils(

sassLoaderVersion = semver.major(require('sass-loader/package.json').version)
) and to vue-cli-plugin-vuetify(
sassLoaderVersion = semver.major(require('sass-loader/package.json').version)
).
vuetify-loader has been added as an optional peer dependency to vue-cli-plugin-vuetify(
const VuetifyLoaderPlugin = require('vuetify-loader/lib/plugin')
).

@paul-soporan paul-soporan changed the title fix(dependencies): add undeclared dependency semver fix(dependencies): add undeclared dependencies Jan 29, 2020
Copy link
Contributor

@DRoet DRoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DRoet DRoet requested a review from johnleider January 29, 2020 15:20
@johnleider johnleider merged commit 670c809 into vuetifyjs:master Jan 29, 2020
@paul-soporan paul-soporan deleted the fix/dependencies/semver branch January 29, 2020 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants