perf(esm-loader): don't parse url if specifier starts with node:#3633
Merged
perf(esm-loader): don't parse url if specifier starts with node:#3633
node:#3633Conversation
Member
I doubt that makes it faster; in practice very few imports will use the |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The ESM loader's
resolvehook can skip parsing the URL if the specifier starts withnode:.Addresses #3603 (comment).
How did you fix it?
Extracted
isBuiltinModulefromapplyPatchintonodeUtilsand made the ESM loader'sresolvehook use it rather than only checkingModule.builtinModules.I also changed the order of the lhs and rhs of
isBuiltinModulesso that it doesn't have to check the entire set first if the specifier starts withnode:.Checklist