feat(pnp): support consolidated ESM loader hooks#3603
Merged
Conversation
arcanis
approved these changes
Oct 21, 2021
Comment on lines
+7
to
+11
| export async function getSource( | ||
| urlString: string, | ||
| context: { format: string }, | ||
| defaultGetSource: typeof getSource, | ||
| ): Promise<{ source: string }> { |
Member
There was a problem hiding this comment.
Perhaps we should contribute those types to DefinitelyTyped?
Member
Author
There was a problem hiding this comment.
Some of these hooks are removed already so we would have to define some of them either way
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The ESM loader added in #2161 doesn't work in
node@>=16.12.0(released a few hours after we merged) due to nodejs/node#37468How did you fix it?
Updated the loader to support the new
loadhookChecklist