Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added notification for destruction of tile improvements [via unit ability] #9754

Merged
merged 3 commits into from
Jul 9, 2023
Merged

Conversation

random271
Copy link
Contributor

Case when it happens #9750

@random271 random271 changed the title Added notification for desctruction of tile improvements [via unit ability] Added notification for destruction of tile improvements [via unit ability] Jul 5, 2023
@SomeTroglodyte
Copy link
Collaborator

FYI: You can soon, if you prefer, mix actions in one notification - e.g. show the tile where the imp was destroyed without selecting any unit on it (LocationAction), and show tile + select the unit on it (MapUnitAction) - if you want.

"soon" means the serialization is still set to backward compatible, so the second action will be lost on reload. But work before that it would.

@SomeTroglodyte
Copy link
Collaborator

SomeTroglodyte commented Jul 5, 2023

And you got the universally beloved "allTranslationsEndWithASpace FAILED" 😸 - actually that's a little misnomer, it's not a translation that needs the trailing space, it's the untranslated template...

@SomeTroglodyte
Copy link
Collaborator

👍 quick - you know you can run tests locally in Studio if you want, right?

@random271
Copy link
Contributor Author

Thought this would be quick, studio is 50/50 on whether my laptop will freeze or not so I am saving on the electricity bills :)

@SomeTroglodyte
Copy link
Collaborator

freeze

Yes, it will "assign" a not quite fitting type to the file and process a monstrous quantity of inappropriate inspections - another reason to never edit translation files in Studio.

@yairm210
Copy link
Owner

yairm210 commented Jul 6, 2023

Oh I just disabled those inspections I think

@yairm210 yairm210 merged commit 8f76164 into yairm210:master Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants