Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XWIKI-15776: The groups displayer store values with a coma at the end #1800

Merged
merged 4 commits into from
Mar 18, 2022
Merged

XWIKI-15776: The groups displayer store values with a coma at the end #1800

merged 4 commits into from
Mar 18, 2022

Commits on Mar 18, 2022

  1. XWIKI-15576: The groups displayer store values with a coma at the end 

      * Refactor ListClass#fromList to take into account multiselect
  * Provide a new ListClass#fromList API with a parameter to filter out
    empty values
  * Provide a new ListClass#getListFromString API with a parameter to
    filter out empty values
  * Use those new APIS in UsersClass/GroupsClass/LevelsClass
  * Add some new tests
    @surli
    surli committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    5f8e7e8 View commit details
    Browse the repository at this point in the history

  2. XWIKI-15576: The groups displayer store values with a coma at the end 

      * Makes explicit the usage of a comma as separator for
    GroupsClass/UsersCLass/LevelsClass
  * Add a fixme comment on ListClass#newProperty since this one looks
    buggy
    @surli
    surli committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    e83ede1 View commit details
    Browse the repository at this point in the history

  3. XWIKI-15576: The groups displayer store values with a coma at the end 

      * Ensure that UsersClass/GroupsClass/LevelsClass does not allow to
    override the separator
    @surli
    surli committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    c094260 View commit details
    Browse the repository at this point in the history

  4. XWIKI-15776: The groups displayer store values with a coma at the end 

      * Override #fromList in GroupsClass/UsersClass/LevelsClass to be sure
    to filter out the empty values there
  * Provide unit tests for the changes
    @surli
    surli committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    2631642 View commit details
    Browse the repository at this point in the history