XWIKI-15776: The groups displayer store values with a coma at the end #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor ListClass#fromList to take into account multiselect
* Provide a new ListClass#fromList API with a parameter to filter out
empty values
* Provide a new ListClass#getListFromString API with a parameter to
filter out empty values
* Use those new APIS in UsersClass/GroupsClass/LevelsClass
* Add some new tests
* Makes explicit the usage of a comma as separator for
GroupsClass/UsersCLass/LevelsClass
* Add a fixme comment on ListClass#newProperty since this one looks
buggy
* Ensure that UsersClass/GroupsClass/LevelsClass does not allow to
override the separator
surli
changed the title
tmortagne
reviewed
Mar 18, 2022
...form-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/UsersClass.java
Show resolved
Hide resolved
tmortagne
reviewed
Mar 18, 2022
| * @param filterEmptyValues if {@code true} filter out the empty values from the list. | ||
| * @since 14.2RC1 | ||
| */ | ||
| protected void fromList(BaseProperty<?> property, List<String> list, boolean filterEmptyValues) |
There was a problem hiding this comment.
Maybe this new filterEmptyValues concept should be an actual configuration of the property class (that happen to be always true for group/user classes) instead of just a parameter in a protected method.
There was a problem hiding this comment.
Could be a global improvment to make indeed. Feels a bit too much for this PR though.
surli
commented
Mar 18, 2022
...form-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/UsersClass.java
Show resolved
Hide resolved
* Override #fromList in GroupsClass/UsersClass/LevelsClass to be sure
to filter out the empty values there
* Provide unit tests for the changes
surli
added a commit
that referenced
this pull request
Mar 18, 2022
…#1800) * Refactor ListClass#fromList to take into account multiselect * Provide a new ListClass#fromList API with a parameter to filter out empty values * Provide a new ListClass#getListFromString API with a parameter to filter out empty values * Use those new APIS in UsersClass/GroupsClass/LevelsClass * Add some new tests * Makes explicit the usage of a comma as separator for GroupsClass/UsersCLass/LevelsClass * Add a fixme comment on ListClass#newProperty since this one looks buggy * Ensure that UsersClass/GroupsClass/LevelsClass does not allow to override the separator * Override #fromList in GroupsClass/UsersClass/LevelsClass to be sure to filter out the empty values there * Provide unit tests for the changes (cherry picked from commit 2dc9f52)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
empty values
filter out empty values