Swift3 #671

mtnbarreto · 2016-09-19T17:31:49Z

No description provided.

Fixed Unit Test (2 errors in HiddenRowsTests.swift which I cannot figure out)

…nableDeselection = false and user deselects a row) Added enableDeselection customisation parameter to SelectorViewController

… size of the app. This only happens if the app uses `preferredFont:forTextStyle`. So no need to worry if you were using other fonts.

Operator fixes Wip Build errors fixed Fixed KVO Warning fixes Additional warning fixes Update Core.swift Fixes with kvo for wrong casts Fixed conversion to NSNumber in KVO Removed development team

Swift 3 Beta 6 Support

XCode 8 GM compatibility

Fix predicate evaluation when values include Optional and or nil

Remove PostalAddressRow from project

Change the access control to open for some classes and methods

Declare some more classes, functions and variables as open

…to follow new swift 3 first method named parameter.

Add .swift-version file to pass cocoapods's validation.

mats-claassen · 2016-09-22T20:49:07Z

CHANGELOG.md

+
+Pull requests associated with this milestone can be found in this [filter](https://github.com/xmartlabs/Eureka/issues?utf8=%E2%9C%93&q=milestone%3A2.0.0%20).
+
+We have made tons of changes in Eureka API to follow the new Swift API design guidelines.


tons of changes to the Eureka API

mats-claassen · 2016-09-22T20:51:04Z

Documentation/Eureka 2.0 Migration Guide.md

@@ -0,0 +1,53 @@
+# Eureka 2.0 Migration  Guide
+
+Eureka 2.0.0 includes complete Swift 3 Compatibility and adopts the new [API Design Guidelines](https://swift.org/documentation/api-design-guidelines/). It also includes new validations build-in feature.


It also includes validations as a build-in features

mats-claassen · 2016-09-22T20:52:05Z

Documentation/Eureka 2.0 Migration Guide.md

+# Eureka 2.0 Migration  Guide
+
+Eureka 2.0.0 includes complete Swift 3 Compatibility and adopts the new [API Design Guidelines](https://swift.org/documentation/api-design-guidelines/). It also includes new validations build-in feature.
+Bring support to swift 3 involves some API updates to follow apple Swift API best practices, we have also changed and deprecated some API.


Apple's
deprecated some API's

mats-claassen · 2016-09-22T20:52:48Z

Documentation/Eureka 2.0 Migration Guide.md

+Removed APIs:
+
+* `PostalAddressRow` and `ImageRow` was deleted.
+*  row has been deleted. You can find it and many other custom rows at EurekaCommunity [organization account](https://github.com/eurekaCommunity).


Remove row has been deleted.

mats-claassen · 2016-09-22T20:53:37Z

Documentation/Eureka 2.0 Migration Guide.md

+Removed APIs:
+
+* `PostalAddressRow` and `ImageRow` was deleted.
+*  row has been deleted. You can find it and many other custom rows at EurekaCommunity [organization account](https://github.com/eurekaCommunity).


You can find them and many other custom rows at EurekaCommunity's

mats-claassen · 2016-09-22T20:54:15Z

Documentation/Eureka 2.0 Migration Guide.md

+
+`highlightCell` and `unhighlightCell` callbacks were deleted, now we should use `row.isHighlighted` from cell update to check from highlighted status and make UI modification according its value.
+
+In case you want to do something when highligth state switches its value you can set up `onCellHighlightChanged` callback.


highlight

…s to open

mtnbarreto · 2016-09-19T18:23:04Z

Example/Example/CustomCells.swift

-                button.setImage(UIImage(named: "checkedDay"), forState: .Selected)
-                button.setImage(UIImage(named: "uncheckedDay"), forState: .Normal)
+                button.setImage(UIImage(named: "checkedDay"), for: .selected)
+                button.setImage(UIImage(named: "uncheckedDay"), for: UIControlState())


should be .normal

mtnbarreto · 2016-09-19T21:57:39Z

Example/Example/Info.plist

@@ -35,6 +35,7 @@
 		<string>UIInterfaceOrientationPortrait</string>
 		<string>UIInterfaceOrientationLandscapeLeft</string>
 		<string>UIInterfaceOrientationLandscapeRight</string>
+		<string>UIInterfaceOrientationPortraitUpsideDown</string>


This line shouldn't have been added.

mats-claassen · 2016-09-26T18:00:53Z

Documentation/Eureka 2.0 Migration Guide.md

-*  row has been deleted. You can find it and many other custom rows at EurekaCommunity [organization account](https://github.com/eurekaCommunity).
-
-`highlightCell` and `unhighlightCell` callbacks were deleted, now we should use `row.isHighlighted` from cell update to check from highlighted status and make UI modification according its value.
+* `PostalAddressRow` and `ImageRow` was deleted. You can find them and many other custom rows at EurekaCommunity [organization account](https://github.com/eurekaCommunity).


PostalAddressRow and ImageRow were deleted

Where can I find these rows in EurekaCommunity?

They are currently in progress. We will soon add them there. I believe the ImageRow has also been added to the Examples project.

Yeah, I just noticed that while looking for examples to make my custom rows working again. Swift 3 really is a pain in the neck!

mats-claassen · 2016-09-26T18:02:07Z

README.md

+* validatesOnChangeAfterBlurred - Validates whenever the row value changes after it resigns first responder for the first time.
+* validatesOnDemand - We should manually validate the row or form by invoking `validate()` method.
+
+If you want to validate the entire form (all the rows) you can invoke Form `validate()` method.


you can invoke form.validate() is more clear

…Eureka community soon. fixes #674

Changing access level of keyboardWillShow and keyboardWillHide methods

Denis Martin and others added 30 commits August 12, 2016 18:50

- First pass... Work in progress

c6de98a

- Travis update

508bdae

no message

5376e06

- Segmentations Error

8fffa9b

Fixed some warnings

e4aa46e

- Xcode 8 beta 2 fix

1eb07a4

Project settings

9d6f43e

Updated Eureka code and Example to Swift 3

9e66569

Fixed UITest (running but failing)

d2372c0

Fixed Unit Test (2 errors in HiddenRowsTests.swift which I cannot figure out)

- Test syntactic fixed for Swift 3

fced0a7

Fix replacing sections in Form

452f184

onSelectSelectableRow will not be called when nothing changes (with e…

4fe3532

…nableDeselection = false and user deselects a row) Added enableDeselection customisation parameter to SelectorViewController

Fixed release configuration

e837c2d

Fixed Xcode beta 3 warnings

007531f

updated readme. Add cell subclassing section

e25cbb0

Fixed a crash when user backgrounded app to change the preferred font…

6af3758

… size of the app. This only happens if the app uses `preferredFont:forTextStyle`. So no need to worry if you were using other fonts.

Also clear imageURL when clearing the row

bb6e05d

Update for Xcode 8 beta 5

8a1042e

minor fix

975df95

Converting to Beta6 support

f8d5874

Operator fixes Wip Build errors fixed Fixed KVO Warning fixes Additional warning fixes Update Core.swift Fixes with kvo for wrong casts Fixed conversion to NSNumber in KVO Removed development team

Merge pull request #616 from Legoless/Swift3

6812995

Swift 3 Beta 6 Support

XCode 8 GM compatibility

f7c6299

Merge pull request #640 from GeneralScripting/Swift3

402998c

XCode 8 GM compatibility

Fix predicate evaluation when values include Optional and or nil

a90766f

Merge pull request #647 from xmartlabs/fix/predicates

c6230f6

Fix predicate evaluation when values include Optional and or nil

remove PostalAddressRow from project

4f7d7ac

Merge pull request #654 from xmartlabs/removePAR

8cf6f5c

Remove PostalAddressRow from project

fix unit tests.

4f6ea64

Eureka build-in validation feature

40db84f

added some basic unit tests.

6ec97ca

mats-claassen and others added 6 commits September 16, 2016 14:05

Merge pull request #664 from yannickl/Swift3

a210bcb

Change the access control to open for some classes and methods

Declare some more classes, functions and variables as open

5e391ee

Merge pull request #666 from xmartlabs/openClasses

c2b0b03

Declare some more classes, functions and variables as open

update readme to new swift 3 syntax, minimal eureka api api refactor …

6674117

…to follow new swift 3 first method named parameter.

api refactor to follow swift 3 API design.

263c780

merge

8896565

mtnbarreto force-pushed the Swift3 branch 6 times, most recently from c44c588 to 7d68bad Compare September 21, 2016 23:05

Martin Barreto and others added 3 commits September 21, 2016 20:19

clean up code.

7d68bad

Add .swift-version to pass cocoapods's validation.

332abcc

Merge pull request #675 from sunbohong/Swift3-fix

3a1de26

Add .swift-version file to pass cocoapods's validation.

mtnbarreto added this to the 2.0.0 milestone Sep 22, 2016

mats-claassen reviewed Sep 22, 2016

View reviewed changes

Martin Barreto and others added 2 commits September 22, 2016 18:02

help doc to migrate to 2.0 version.

7aa2d18

Changing access level of keyboardWillShow and keyboardWillHide method…

a2ec90b

…s to open

mtnbarreto commented Sep 26, 2016

View reviewed changes

mats-claassen reviewed Sep 26, 2016

View reviewed changes

mtnbarreto force-pushed the Swift3 branch from c4df9fc to 5220379 Compare September 26, 2016 18:39

code review changes.

5220379

mtnbarreto force-pushed the Swift3 branch from 814185e to 23ca6f7 Compare September 26, 2016 20:31

Martin Barreto added 2 commits September 26, 2016 17:46

Moved ImageRow to example project. Will be provided as Custom row at …

23ca6f7

…Eureka community soon. fixes #674

Merge pull request #681 from svedm/Swift3

96e14e8

Changing access level of keyboardWillShow and keyboardWillHide methods

mtnbarreto merged commit 3efe00e into master Sep 26, 2016

minor fix

1a7ef72

mtnbarreto deleted the Swift3 branch October 3, 2016 21:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Swift3 #671

Swift3 #671

mtnbarreto commented Sep 19, 2016

mats-claassen Sep 22, 2016

mats-claassen Sep 22, 2016

mats-claassen Sep 22, 2016

mats-claassen Sep 22, 2016

mats-claassen Sep 22, 2016

mats-claassen Sep 22, 2016

mtnbarreto Sep 19, 2016

mtnbarreto Sep 19, 2016

mats-claassen Sep 26, 2016

weyert Sep 27, 2016

mats-claassen Sep 27, 2016

weyert Sep 27, 2016

mats-claassen Sep 26, 2016


		Pull requests associated with this milestone can be found in this [filter](https://github.com/xmartlabs/Eureka/issues?utf8=%E2%9C%93&q=milestone%3A2.0.0%20).

		We have made tons of changes in Eureka API to follow the new Swift API design guidelines.

		@@ -0,0 +1,53 @@
		# Eureka 2.0 Migration Guide

		Eureka 2.0.0 includes complete Swift 3 Compatibility and adopts the new [API Design Guidelines](https://swift.org/documentation/api-design-guidelines/). It also includes new validations build-in feature.


		`highlightCell` and `unhighlightCell` callbacks were deleted, now we should use `row.isHighlighted` from cell update to check from highlighted status and make UI modification according its value.

		In case you want to do something when highligth state switches its value you can set up `onCellHighlightChanged` callback.

Swift3 #671

Swift3 #671

Conversation

mtnbarreto commented Sep 19, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment