Declare some more classes, functions and variables as open #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtnbarreto
reviewed
Sep 16, 2016
| @@ -137,7 +137,7 @@ extension BaseRow { | |||
| /** | |||
| Evaluates if the row should be hidden or not and updates the form accordingly | |||
| */ | |||
| public final func evaluateHidden() { | |||
| public func evaluateHidden() { | |||
| @@ -156,7 +156,7 @@ extension BaseRow { | |||
| /** | |||
| Evaluates if the row should be disabled or not and updates it accordingly | |||
| */ | |||
| public final func evaluateDisabled() { | |||
| public func evaluateDisabled() { | |||
| @@ -549,7 +549,7 @@ open class FormViewController : UIViewController, FormViewControllerProtocol { | |||
| /** | |||
| Called when a cell becomes first responder | |||
| */ | |||
| public final func beginEditing<T:Equatable>(_ cell: Cell<T>) { | |||
| public func beginEditing<T:Equatable>(_ cell: Cell<T>) { | |||
| @@ -567,7 +567,7 @@ open class FormViewController : UIViewController, FormViewControllerProtocol { | |||
| /** | |||
| Called when a cell resigns first responder | |||
| */ | |||
| public final func endEditing<T:Equatable>(_ cell: Cell<T>) { | |||
| public func endEditing<T:Equatable>(_ cell: Cell<T>) { | |||
|
This is an evil pull request lmao |
|
hahaha. it was merged by me 😱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #646
fixes #643
@xmartlabs/eureka