forked from appsmithorg/appsmith
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: replacing hard coded string (appsmithorg#25132)
## Description > TL;DR replacing hardcoded strings to use the same macros in EE implementation #### Type of change - Chore (housekeeping or task changes that don't impact user perception) #### How Has This Been Tested? - [x] Manual ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag
- Loading branch information
1 parent
8e868b3
commit 820beae
Showing
3 changed files
with
31 additions
and
6 deletions.
There are no files selected for viewing
9 changes: 9 additions & 0 deletions
9
...erver/appsmith-server/src/main/java/com/appsmith/server/constants/AnalyticsConstants.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package com.appsmith.server.constants; | ||
|
||
import com.appsmith.server.constants.ce.AnalyticsConstantsCE; | ||
|
||
/** | ||
* Class to store instrumentation constants only | ||
*/ | ||
public class AnalyticsConstants extends AnalyticsConstantsCE { | ||
} |
10 changes: 10 additions & 0 deletions
10
.../appsmith-server/src/main/java/com/appsmith/server/constants/ce/AnalyticsConstantsCE.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package com.appsmith.server.constants.ce; | ||
|
||
public class AnalyticsConstantsCE { | ||
public static final String ENVIRONMENT_ID_SHORTNAME = "envId"; | ||
public static final String DATASOURCE_ID_SHORTNAME = "dsId"; | ||
public static final String DATASOURCE_NAME_SHORTNAME = "dsName"; | ||
public static final String DATASOURCE_IS_TEMPLATE_SHORTNAME = "dsIsTemplate"; | ||
public static final String DATASOURCE_IS_MOCK_SHORTNAME = "dsIsMock"; | ||
public static final String DATASOURCE_CREATED_AT_SHORTNAME = "dsCreatedAt"; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters