Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replacing hard coded string #25132

Merged
merged 2 commits into from
Jul 6, 2023
Merged

chore: replacing hard coded string #25132

merged 2 commits into from
Jul 6, 2023

Conversation

sondermanish
Copy link
Contributor

@sondermanish sondermanish commented Jul 5, 2023 •
edited
Loading

Description

TL;DR replacing hardcoded strings to use the same macros in EE implementation

Type of change

  • Chore (housekeeping or task changes that don't impact user perception)

How Has This Been Tested?

  • Manual

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jul 5, 2023
@sondermanish sondermanish requested a review from nidhi-nair July 5, 2023 11:54
@sondermanish sondermanish self-assigned this Jul 5, 2023
@sondermanish
Copy link
Contributor Author

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5464078445.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 25132.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=25132&runId=5464078445_1

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5464078445.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@sondermanish sondermanish requested a review from nidhi-nair July 6, 2023 05:22
@sondermanish
Copy link
Contributor Author

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5471866434.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 25132.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=25132&runId=5471866434_1

subrata71
subrata71 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@subrata71 subrata71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sondermanish
Copy link
Contributor Author

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5471910504.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 25132.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=25132&runId=5471910504_1

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5471866434.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5471910504.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@sondermanish sondermanish merged commit 820beae into release Jul 6, 2023
@sondermanish sondermanish deleted the chore/string-to-macros branch July 6, 2023 07:23
@riteshkew riteshkew added the Environments Product Issues related to datasource environments label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subrata71 subrata71 subrata71 approved these changes

@nidhi-nair nidhi-nair Awaiting requested review from nidhi-nair

Assignees

@sondermanish sondermanish

Labels
Environments Product Issues related to datasource environments skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sondermanish @subrata71 @nidhi-nair @riteshkew