fix: update placeholder text for port numbers in datasource form (app…

…smithorg#24961)
xethanx · Jul 6, 2023 · 37e4154 · 37e4154
1 parent 5ef23fc
commit 37e4154
Show file tree

Hide file tree

Showing 4 changed files with 44 additions and 3 deletions.
diff --git a/app/client/cypress/e2e/Sanity/Datasources/Port_Number_Placeholder_Spec.ts b/app/client/cypress/e2e/Sanity/Datasources/Port_Number_Placeholder_Spec.ts
@@ -0,0 +1,41 @@
+import { agHelper, dataSources } from "../../../support/Objects/ObjectsCore";
+
+describe("Test placeholder value for port number for all datasources - tests #24960", () => {
+  it("1. Test datasource port number placeholder", () => {
+    // MsSQL
+    dataSources.NavigateToDSCreateNew();
+    dataSources.CreatePlugIn("Microsoft SQL Server");
+
+    let expectedPlaceholderValue = "1433";
+    agHelper.AssertAttribute(
+      dataSources._port,
+      "placeholder",
+      expectedPlaceholderValue,
+    );
+    dataSources.SaveDSFromDialog(false);
+
+    // Oracle
+    dataSources.NavigateToDSCreateNew();
+    dataSources.CreatePlugIn("Oracle");
+
+    expectedPlaceholderValue = "1521";
+    agHelper.AssertAttribute(
+      dataSources._port,
+      "placeholder",
+      expectedPlaceholderValue,
+    );
+    dataSources.SaveDSFromDialog(false);
+
+    // SMTP
+    dataSources.NavigateToDSCreateNew();
+    dataSources.CreatePlugIn("SMTP");
+
+    expectedPlaceholderValue = "25";
+    agHelper.AssertAttribute(
+      dataSources._port,
+      "placeholder",
+      expectedPlaceholderValue,
+    );
+    dataSources.SaveDSFromDialog(false);
+  });
+});
diff --git a/app/server/appsmith-plugins/mssqlPlugin/src/main/resources/form.json b/app/server/appsmith-plugins/mssqlPlugin/src/main/resources/form.json
@@ -37,7 +37,7 @@
               "configProperty": "datasourceConfiguration.endpoints[*].port",
               "dataType": "NUMBER",
               "controlType": "KEYVALUE_ARRAY",
-              "placeholderText": "1443"
+              "placeholderText": "1433"
             }
           ]
         },

diff --git a/app/server/appsmith-plugins/oraclePlugin/src/main/resources/form.json b/app/server/appsmith-plugins/oraclePlugin/src/main/resources/form.json
@@ -21,7 +21,7 @@
               "configProperty": "datasourceConfiguration.endpoints[*].port",
               "dataType": "NUMBER",
               "controlType": "KEYVALUE_ARRAY",
-              "placeholderText": "6003"
+              "placeholderText": "1521"
             }
           ]
         },

diff --git a/app/server/appsmith-plugins/smtpPlugin/src/main/resources/form.json b/app/server/appsmith-plugins/smtpPlugin/src/main/resources/form.json
@@ -20,7 +20,7 @@
               "configProperty": "datasourceConfiguration.endpoints[*].port",
               "dataType": "NUMBER",
               "controlType": "KEYVALUE_ARRAY",
-              "placeholderText": "587"
+              "placeholderText": "25"
             }
           ]
         }