Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update placeholder text for port numbers in datasource form #24961

Merged
merged 8 commits into from
Jul 6, 2023
Merged

fix: update placeholder text for port numbers in datasource form #24961

merged 8 commits into from
Jul 6, 2023

Conversation

sumitsum
Copy link
Contributor

@sumitsum sumitsum commented Jun 30, 2023 •
edited by prapullc
Loading

Description

  • Fix placeholder text for port numbers in datasource form for Oracle, MsSQL and SMTP plugins.
  • This PR has added Cypress test cases for the integrations that are being updated by this PR only (in the interest of time). Adding similar test cases for all other integrations is being tracked via this issue and will be taken up separately.

PR fixes following issue(s)

Fixes #24960

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

  • Manual
  • JUnit

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@github-actions github-actions bot added Backend This marks the issue or pull request to reference server code Query & JS Pod Issues related to the query & JS Pod Bug Something isn't working Datasources Issues related to configuring datasource on appsmith Integrations Product Issues related to a specific integration Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. labels Jun 30, 2023
@sumitsum sumitsum marked this pull request as draft July 3, 2023 05:14
@sumitsum sumitsum marked this pull request as ready for review July 4, 2023 10:31
@sumitsum sumitsum mentioned this pull request Jul 4, 2023
Closed
1 task
@sumitsum
Copy link
Contributor Author

sumitsum commented Jul 4, 2023

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5453800648.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24961.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24961&runId=5453800648_1

sneha122
sneha122 previously approved these changes Jul 4, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5453800648.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Git/GitDiscardChange/DiscardChanges_spec.js

  2. cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js
  3. cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad1_Spec.ts
To know the list of identified flaky tests - Refer here

Aishwarya-U-R
Aishwarya-U-R reviewed Jul 4, 2023
View reviewed changes
Copy link
Contributor

@Aishwarya-U-R Aishwarya-U-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving Cypress changes!

app/client/cypress/e2e/Sanity/Datasources/Port_Number_Placeholder_Spec.ts Outdated Show resolved Hide resolved
@sumitsum sumitsum requested a review from Aishwarya-U-R July 4, 2023 12:41
@sumitsum
Copy link
Contributor Author

sumitsum commented Jul 4, 2023

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5454820008.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 24961.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=24961&runId=5454820008_1

@sumitsum
Copy link
Contributor Author

sumitsum commented Jul 4, 2023

/build-deploy-preview

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5454824710.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 24961.
recreate: .

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Deploy-Preview-URL: https://ce-24961.dp.appsmith.com

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5454820008.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Git/GitDiscardChange/DiscardChanges_spec.js

  2. cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad1_Spec.ts
To know the list of identified flaky tests - Refer here

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5454820008.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/ClientSide/Git/GitDiscardChange/DiscardChanges_spec.js

  2. cypress/e2e/ServerSide/OnLoadTests/JSOnLoad1_Spec.ts
To know the list of identified flaky tests - Refer here

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5454820008.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@prapullc prapullc added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Jul 6, 2023
@sumitsum sumitsum merged commit 37e4154 into release Jul 6, 2023
@sumitsum sumitsum deleted the fix/fix_mssql_port_no_placeholder branch July 6, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aishwarya-U-R Aishwarya-U-R Aishwarya-U-R approved these changes

@sneha122 sneha122 Awaiting requested review from sneha122

Assignees
No one assigned
Labels
Backend This marks the issue or pull request to reference server code Bug Something isn't working Datasources Issues related to configuring datasource on appsmith Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Update faulty placeholder texts for port number in datasource forms
4 participants
@sumitsum @sneha122 @Aishwarya-U-R @prapullc