Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ship context to position rolls and display of total armor #1548

Merged
merged 13 commits into from
Mar 11, 2024

Conversation

marvin9257
Copy link
Collaborator

@marvin9257 marvin9257 commented Mar 4, 2024

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    features

  • What is the current behavior? (You can also link to an open issue here)

  • No ship context for position chat rolls
  • Traveller sheet displays incremental value for secondary armor (not total)
  • Can't have optional flavor for ship position chat rolls
  • Healing macro doesn't work
  • CE SRD skills all default to STR
  • Monk's Enhanced Journal, Journal Entries have styling issues
  • What is the new behavior (if this is a feature change)?
  • Ship position rolls now include ship.system the context
  • Display option to show Total armor (primary + secondary) on Traveller sheet. Also improve tooltips for protection types
  • Add optional # separator for flavor text with ship position chat rolls
  • fix healing macro
  • CE SRD skills default to "---" NONE
  • Add style corrections for MEJ
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

@marvin9257
Copy link
Collaborator Author

Partially address #787

@marvin9257 marvin9257 linked an issue Mar 11, 2024 that may be closed by this pull request
@marvin9257
Copy link
Collaborator Author

@marvin9257 marvin9257 merged commit 4689123 into xdy:master Mar 11, 2024
8 checks passed
@marvin9257 marvin9257 deleted the add-ship-context-to-position-rolls branch March 11, 2024 17:57
github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
# [4.23.0](v4.22.0...v4.23.0) (2024-03-11)

### Features

* Add ship context to position rolls and display of total armor ([#1548](#1548)) ([4689123](4689123))
Copy link

🎉 This PR is included in version 4.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant