Merge master into update guidance improvement feature branch #5425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move tests from build to build-tests so the get run by travis script. Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Data Sources with derive type are not monotonically increasing like counter ones and may lead to strange metrics being produced. Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Previously the values were just clamped before being applied the transform function from the client. Now the values marked as unknown values after having the transform applied, in case the transforms do not check for out-of-bounds values. Treating out-of-bounds values as Unknown matches rrdtool's behaviour. Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
CA-322008: Stop treating Derive datasources as counters
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
tests: add json marshalling
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Test array length invariant in the rrds Test how rrd_updates are populated (depends a lot on current implementation) Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Bounded values in RRAs
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Fix adding a datasource to an rrd
opam: refresh metadata
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
Defines `default_path_env_pair` as the default value used by optional parameter `?env`. External clients of `Forkhelpers` need to include the value `default_path_env_pair` when passing an argument to `?env`. Now this value is defined inside the module for client use. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
Moves `config_root` under `observer_confi_dir` in `xapi_globs.ml`. Adds `observer_conf_path` function that constructs the path based on `uuid`. Removes `~config_root` parameter. There were various ways to define paths is `Dom0ObserverConfig` which increase the probabilty of introducing bugs in the future. This consolidates them into `observer_conf_path_of`. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
Splits functionality `env_vars_of_observer` into `traceparent_of_dbg` under `debuginfo.ml` and `env_vars_of_component` under `xapi_observer_components.ml. Doing the processing of traceparent and of the necessary observer env vars under their respective modules increases the readablity of `sm_exec.ml`. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
…le otherwise): Add a comment based on Pau's explanation for the change in the PR: # Open file at pos 0, creating but not truncating the file(not possible otherwise): Signed-off-by: Bernhard Kaindl <bernhardkaindl7@gmail.com>
Signed-off-by: Bernhard Kaindl <bernhardkaindl7@gmail.com>
…/CP-46377 CP-46377: Add env vars `TRACEPARENT` & `OBSERVER_CONFIG_DIR` to `exec_xmlrpc` calls
Otherwise dune runs them for all packages in the repository, failing if they don't depend on the xapi-rrd library. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
This will be useful for checking some new fields introduced in Xen-4.15+ Signed-off-by: Edwin Török <edwin.torok@cloud.com>
Only `platform:nested-virt=true` sets this field. The previous experimental field `platform:exp-nested-hvm=true` is now dropped. `platform:nested-virt` has been present in the product since Dundee, any users of `exp-nested-hvm` can be updated to use that instead. This doesn't mean that nested virt is supported yet: its implementation is still incomplete. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
`platform:msr-relaxed=true` Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Signed-off-by: Edwin Török <edwin.torok@cloud.com>
`platform:vpmu=true`. For this to work the Xen cmdline also needs to be edited to remove the watchdog, and enable vpmu. In the future this may become easier. VPMU doesn't require HVM. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
Set to 2 if the host supports it. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Signed-off-by: Edwin Török <edwin.torok@cloud.com>
Always set to 0. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Signed-off-by: Edwin Török <edwin.torok@cloud.com>
Signed-off-by: Edwin Török <edwin.torok@cloud.com>
Merge Xen-4.17 update
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
ci: delete needless files from base image
Signed-off-by: Edwin Török <edwin.torok@cloud.com>
Should have more disk space. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
…nospc Try to avoid ENOSPC in CI
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Gang Ji <gang.ji@citrix.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/update-guidance-improvement #5425 +/- ##
======================================================================
Coverage ? 45.38%
======================================================================
Files ? 18
Lines ? 2937
Branches ? 0
======================================================================
Hits ? 1333
Misses ? 1604
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
minglumlu
approved these changes
Feb 5, 2024
liulinC
approved these changes
Feb 5, 2024
pytype_reporter extracted 49 problem reports from pytype output.You can check the results of the job here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is the change (in the merging commit: bfbe9d7 when merging from master:
[gangj@xenrt1015818055 scm]$ git show bfbe9d7
commit bfbe9d7 (HEAD -> private/gangj/ugi.a.merge_master.3-24.02.05)
Merge: 2ce256e e3602e1
Author: Gang Ji gang.ji@citrix.com
Date: Mon Feb 5 10:37:38 2024 +0800
diff --cc ocaml/idl/schematest.ml
index 7f029c22d,cb84842f7..b3f86ab2d
--- a/ocaml/idl/schematest.ml
+++ b/ocaml/idl/schematest.ml
@@@ -3,7 -3,7 +3,7 @@@ let hash x = Digest.string x |> Digest.
(* BEWARE: if this changes, check that schema has been bumped accordingly in
ocaml/idl/datamodel_common.ml, usually schema_minor_vsn *)
- let last_known_schema_hash = "49c51c0b5e895f42a1c9c19abb038b41"
-let last_known_schema_hash = "1e43ef93af9de55620fda75281e8a992"
++let last_known_schema_hash = "5b597309a69b2c7b9053446fa338c701"
let current_schema_hash : string =
let open Datamodel_types in
diff --cc quality-gate.sh
index bf8f561af,224e852aa..d33edacff
--- a/quality-gate.sh
+++ b/quality-gate.sh
@@@ -3,7 -3,7 +3,7 @@@
set -e
list-hd () {
- N=315
- N=318
++ N=316
LIST_HD=$(git grep -r --count 'List.hd' -- **/*.ml | cut -d ':' -f 2 | paste -sd+ - | bc)
if [ "$LIST_HD" -eq "$N" ]; then
echo "OK counted $LIST_HD List.hd usages"