Skip to content

Fix 'make install' and add a CI rule #5310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2023
Merged

Fix 'make install' and add a CI rule #5310

merged 2 commits into from
Dec 20, 2023

Conversation

@edwintorok
Copy link
Contributor

Opening PR to test CI, this will also need a .spec change

@edwintorok
Copy link
Contributor Author

Hmm we have some bugs in the CI still:

dune build --profile=release \
	ocaml/sdk-gen/c/gen_c_binding.exe \
	ocaml/sdk-gen/csharp/gen_csharp_binding.exe \
	ocaml/sdk-gen/java/main.exe \
	ocaml/sdk-gen/powershell/gen_powershell_binding.exe
Error: A running dune (pid: 79969) instance has locked the build directory.
If this is not the case, please delete _build/.lock
Error: A running dune (pid: 79969) instance has locked the build directory.
If this is not the case, please delete _build/.lock
Error: A running dune (pid: 79969) instance has locked the build directory.
If this is not the case, please delete _build/.lock

@edwintorok edwintorok marked this pull request as draft December 20, 2023 14:30
@edwintorok
ci(main): add a make install smoketest
34a3df0 
Signed-off-by: Edwin Török <edwin.torok@cloud.com>
@edwintorok
fix(Makefile): remove xva.py from the Makefile
75b5fc0 
Fixes: 2a6aaae ("CP-45974: Porting examples to python3,as per Edwin Torok an Rob Hoes XVA.py is not required anymore,deleting it from repo.")

Signed-off-by: Edwin Török <edwin.torok@cloud.com>
@edwintorok
Copy link
Contributor Author

That is probably a preexinsting bug in the Makefile, I'll try without '-j'. I wonder why we're not seeing this in koji.

@psafont psafont marked this pull request as ready for review December 20, 2023 14:48
@edwintorok edwintorok merged commit 6bd5132 into xapi-project:master Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robhoes robhoes robhoes approved these changes

@psafont psafont psafont approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edwintorok @robhoes @psafont