Merge pull request #5310 from edwintorok/master

Fix 'make install' and add a CI rule

Author: edwintorok

.github/workflows/main.yml

@@ -86,6 +86,11 @@ jobs:
           wget -O /opt/xensource/sm/XE_SR_ERRORCODES.xml https://raw.githubusercontent.com/xapi-project/sm/master/drivers/XE_SR_ERRORCODES.xml
           opam exec -- make sdk
 
+      - name: Make install smoketest
+        run: |
+          opam exec -- make install DESTDIR=$(mktemp -d)
+          opam exec -- make install DESTDIR=$(mktemp -d) BUILD_PY2=NO
+
       - name: Uninstall unversioned packages and remove pins
         # This should purge them from the cache, unversioned package have
         # 'master' as its version

scripts/Makefile

@@ -179,7 +179,6 @@ endif
 	$(IDATA) examples/python/inventory.py $(DESTDIR)$(SITE3_DIR)/
 	$(IPROG) examples/python/echo.py $(DESTDIR)$(PLUGINDIR)/echo
 	$(IPROG) examples/python/shell.py $(DESTDIR)$(LIBEXECDIR)/shell.py
-	$(IPROG) examples/python/xva.py $(DESTDIR)$(OPTDIR)/bin/xva-rewrite-scsiid
 # poweron
 	$(IPROG) poweron/wlan.py $(DESTDIR)$(PLUGINDIR)/wlan.py
 	$(IPROG) poweron/wlan.py $(DESTDIR)$(PLUGINDIR)/wake-on-lan