Skip to content

Switch over to v6 interface from xcp-idl #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 5, 2016
Merged

Switch over to v6 interface from xcp-idl #2792

merged 3 commits into from
Oct 5, 2016

Conversation

@robhoes
Copy link
Member

@robhoes robhoes commented Oct 4, 2016

No description provided.

robhoes added 3 commits October 4, 2016 21:50
@robhoes
Use apply_edition_internal in license_add/remove
39e2120 
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
@robhoes
Switch over to V6_client (from xcp-idl)
02a6181 
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
@robhoes
Remove now-obsolete code
4e985a0 
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
@robhoes
Copy link
Member Author

robhoes commented Oct 4, 2016

Depends on xapi-project/xcp-idl#132

lindig
lindig reviewed Oct 5, 2016
View reviewed changes
Copy link
Contributor

@lindig lindig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While big, many changes are mostly mechanical. I don't see a reason not to merge this but obviously the devil is in the details and these are hard to judge in a change like this.

@robhoes robhoes merged commit ca4c38e into xapi-project:master Oct 5, 2016
@robhoes
Copy link
Member Author

robhoes commented Oct 5, 2016

It's mostly deleting stuff :)

@robhoes robhoes deleted the transform branch October 26, 2017 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lindig lindig lindig left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robhoes @lindig