Add v6 interface #132
Merged
Add v6 interface #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
lindig
reviewed
Oct 5, 2016
| open V6_interface | ||
| open Xcp_client | ||
|
|
||
| let retry_econnrefused f = |
There was a problem hiding this comment.
Two minor thoughts: I would have called this connect and would have used a counter for the retry-loop. Right now you can only retry once but a counter and a limit would be more flexible. Not requesting a change, though.
|
|
||
| type debug_info = string | ||
|
|
||
| exception Invalid_edition of string |
There was a problem hiding this comment.
Would it be easier for a client to handle one exception that carries a sum type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.