[dotnet] Ensure appropriate IL Strip value for multi-rid builds #21378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfbjarne
reviewed
Oct 7, 2024
| @@ -890,7 +890,7 @@ | |||
| <EnableAssemblyILStripping>false</EnableAssemblyILStripping> | |||
|
|
|||
| <!-- Strip if we are AOT and Release --> | |||
| <EnableAssemblyILStripping Condition="'$(_RunAotCompiler)' == 'true' And '$(Configuration)' == 'Release'">true</EnableAssemblyILStripping> | |||
| <EnableAssemblyILStripping Condition="'$(_RunAotCompiler)' == 'true' And '$(Configuration)' == 'Release' And '$(_IsMultiRidBuild)' != 'true'">true</EnableAssemblyILStripping> | |||
dalexsoto
approved these changes
Oct 8, 2024
dalexsoto
requested changes
Oct 8, 2024
There was a problem hiding this comment.
@haritha-mohan you need to push this to a branch in the main repo not from a fork so it actually builds the PR
thanks for catching that! was moving between repos 😅 also need to add a test here so will open a updated PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsMultiRidBuildtracks if we are executing an inner build for a multi-rid case. With this approach, if the user specifies a value forEnableAssemblyILStrippingit will still be honored. Otherwise, to ensure we don't duplicate assemblies when merging the app bundles due to a strip vs non-strip scenario, IL stripping for the multi-rid build is disabled by default.There have been past examples of optimizing in the outer-build: #12847
But because IL Stripping is contingent on the evaluation of other RID-specific properties, not sure if that is a feasible approach here.
Fixes #17115