Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable IL Stripping if any RID for a universal app has it disabled by default #17115

Open
rolfbjarne opened this issue Dec 22, 2022 · 0 comments · May be fixed by #21391
Open

Disable IL Stripping if any RID for a universal app has it disabled by default #17115

rolfbjarne opened this issue Dec 22, 2022 · 0 comments · May be fixed by #21391
Assignees
@haritha-mohan
Labels
app-size enhancement The issue or pull request is an enhancement
Milestone
.NET 10

Comments

@rolfbjarne
Copy link
Member

Currently we decide whether we should strip IL on a per-RID basis.

This turns out unfortunate when building a universal app where one RID defaults to stripping and the other one doesn't - maccatalyst-x64 + maccatalyst-arm64 is an example.

In that case we should disable IL stripping, so that we don't end up including assemblies twice in the app bundle, once stripped and once unstripped (which, size-wise, is worse than not stripping anything).

Ref: #16847
@rolfbjarne rolfbjarne added this to the .NET 8 milestone Dec 22, 2022
@rolfbjarne rolfbjarne added enhancement The issue or pull request is an enhancement app-size labels Dec 22, 2022
@rolfbjarne rolfbjarne mentioned this issue Dec 22, 2022
Closed
@rolfbjarne rolfbjarne modified the milestones: .NET 8, .NET 9 Sep 11, 2023
@rolfbjarne rolfbjarne modified the milestones: .NET 9, .NET 10 Sep 26, 2024
haritha-mohan added a commit that referenced this issue Oct 2, 2024
@haritha-mohan
[dotnet] Ensure appropriate IL Strip value for multi-rid builds
38e2983 
Using logical conjunction, ensure an appropriate value is updated
for IL Stripping in multi-rid builds.

Fixes #17115
haritha-mohan added a commit to haritha-mohan/xamarin-macios that referenced this issue Oct 5, 2024
@haritha-mohan
[dotnet] Ensure appropriate IL Strip value for multi-rid builds
9034068 
Fixes xamarin#17115
This was referenced Oct 5, 2024
Closed
Open
haritha-mohan added a commit that referenced this issue Oct 19, 2024
@haritha-mohan
[dotnet] Ensure appropriate IL Strip value for multi-rid builds
e53ff8b 
Fixes #17115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haritha-mohan haritha-mohan

Labels
app-size enhancement The issue or pull request is an enhancement
Projects
None yet
Milestone
.NET 10
Development

Successfully merging a pull request may close this issue.

[dotnet] Ensure appropriate IL Strip value for multi-rid builds xamarin/xamarin-macios
2 participants
@rolfbjarne @haritha-mohan