This repository was archived by the owner on May 15, 2024. It is now read-only.
GH-1121 If VC is null use TraitCollection #1144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmontemagno
added
the
awaiting-review
Redth
approved these changes
Mar 3, 2020
Redth
added a commit
that referenced
this pull request
Mar 3, 2020
* Implement vertical accuracy in GeoLocation API (#1103) * Location: add property 'VerticalAccuracy' (#1099) * vertical accuracy is only available in Android API level 26 and above (#1099) * update Samples app to show vertical accuracy on GeolocationPage * add missing documentation bits for Location.VerticalAccuracy * .gitattributes: get better diff context for C# code (#1115) * Location.VerticalAccuracy: add runtime check for Android version (#1099) (#1116) * the compile-time check is not enough * it crashed on old Android versions (<8.0) * GH-1102 Fix launcher on older devices (#1120) * Update Launcher.ios.tvos.cs * OpenUrlAsync was introduced in iOS 10 not 12 https://docs.microsoft.com/en-us/dotnet/api/uikit.uiapplication.openurlasync?view=xamarin-ios-sdk-12 * Fix trailing whitespace * Really? fix whitespace * Really! Fix whitespace * Fixes #1129 - set empty required declarations on UWP (#1133) * Fixes #1129 - set empty required declarations on UWP * Update Permissions.uwp.cs * Update Xamarin.Essentials.csproj (#1136) * GH-1142 AccessBackgroundLocation only when compile & running Q (#1143) * AccessBackgroundLocation only when compile & running Q * put if compile check around permission * GH-1121 If VC is null use TraitCollection (#1144) * Fixes #1123 (#1126) * Update PlacemarkExtensions.xml (#1132) Co-authored-by: Janus Weil <janus@gcc.gnu.org> Co-authored-by: James Montemagno <james.montemagno@gmail.com> Co-authored-by: Michael <Michael@ZPF.fr>
5 tasks
jamesmontemagno
added a commit
that referenced
this pull request
Mar 6, 2020
* Implement vertical accuracy in GeoLocation API (#1103) * Location: add property 'VerticalAccuracy' (#1099) * vertical accuracy is only available in Android API level 26 and above (#1099) * update Samples app to show vertical accuracy on GeolocationPage * add missing documentation bits for Location.VerticalAccuracy * .gitattributes: get better diff context for C# code (#1115) * Location.VerticalAccuracy: add runtime check for Android version (#1099) (#1116) * the compile-time check is not enough * it crashed on old Android versions (<8.0) * GH-1102 Fix launcher on older devices (#1120) * Update Launcher.ios.tvos.cs * OpenUrlAsync was introduced in iOS 10 not 12 https://docs.microsoft.com/en-us/dotnet/api/uikit.uiapplication.openurlasync?view=xamarin-ios-sdk-12 * Fix trailing whitespace * Really? fix whitespace * Really! Fix whitespace * Fixes #1129 - set empty required declarations on UWP (#1133) * Fixes #1129 - set empty required declarations on UWP * Update Permissions.uwp.cs * Update Xamarin.Essentials.csproj (#1136) * GH-1142 AccessBackgroundLocation only when compile & running Q (#1143) * AccessBackgroundLocation only when compile & running Q * put if compile check around permission * GH-1121 If VC is null use TraitCollection (#1144) * Fixes #1123 (#1126) * Update PlacemarkExtensions.xml (#1132) Co-authored-by: Janus Weil <janus@gcc.gnu.org> Co-authored-by: James Montemagno <james.montemagno@gmail.com> Co-authored-by: Michael <Michael@ZPF.fr> Co-authored-by: Jonathan Dick <jodick@microsoft.com> Co-authored-by: Janus Weil <janus@gcc.gnu.org> Co-authored-by: Michael <Michael@ZPF.fr>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
VC may be null at startup so use traitcollection
Bugs Fixed
Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.
API Changes
None.
Behavioral Changes
Should now work at startup.
PR Checklist