Implement vertical accuracy in GeoLocation API #1103

janusw · 2020-02-18T10:41:24Z

Description of Change

This extends the GeoLocation API to provide the vertical accuracy.

Bugs Fixed

Related to issue [Enhancement] Provide accuracy of altitude in GeoLocation API #1099

API Changes

List all API changes here (or just put None), example:

Added:

double? Location.VerticalAccuracy { get; set; }

Changed:

None

Behavioral Changes

None.

PR Checklist

Has tests (if omitted, state reason in description)
Has samples (if omitted, state reason in description)
Rebased on top of master at time of PR
Changes adhere to coding standard
Updated documentation (see walkthrough)

…xamarin#1099)

Redth · 2020-02-19T01:59:19Z

Question about the value on each platform. Are we sure this is accuracy in meters on iOS, Android and UWP? Just want to double check we don't need any code to normalize values here.

janusw · 2020-02-19T10:29:33Z

Question about the value on each platform. Are we sure this is accuracy in meters on iOS, Android and UWP?

Yes, the links to the documentation of the API calls on each platform can be found in #1099. All three explicitly mention that the returned value is in meters.

janusw · 2020-02-23T14:58:33Z

@Redth Thanks for the approval! Any chance to still get this into the 1.5.0 release?

Redth · 2020-02-23T15:14:43Z

Yes I think we can put this into 1.5 still

janusw · 2020-02-23T19:51:12Z

Thanks a lot for merging!

Unfortunately I discovered just in this very moment a problem with older Android versions: The compile-time check does not seem to be sufficient, and we'll need a runtime check in addition :/

Sorry about that. I'll open a follow-up PR with the fix shortly!

* Implement vertical accuracy in GeoLocation API (#1103) * Location: add property 'VerticalAccuracy' (#1099) * vertical accuracy is only available in Android API level 26 and above (#1099) * update Samples app to show vertical accuracy on GeolocationPage * add missing documentation bits for Location.VerticalAccuracy * .gitattributes: get better diff context for C# code (#1115) * Location.VerticalAccuracy: add runtime check for Android version (#1099) (#1116) * the compile-time check is not enough * it crashed on old Android versions (<8.0) * GH-1102 Fix launcher on older devices (#1120) * Update Launcher.ios.tvos.cs * OpenUrlAsync was introduced in iOS 10 not 12 https://docs.microsoft.com/en-us/dotnet/api/uikit.uiapplication.openurlasync?view=xamarin-ios-sdk-12 * Fix trailing whitespace * Really? fix whitespace * Really! Fix whitespace Co-authored-by: Janus Weil <janus@gcc.gnu.org> Co-authored-by: James Montemagno <james.montemagno@gmail.com>

* WebAuthenticator API (#1062) * Initial work for WebAuthenticator API * Fix page loaded in sample * Fix weird generated item * Fix error message * Fix filename, too many .'s * Remove unnecessary comment * Tweak AppleSignIn API * Cancel any previous waiting tasks * Use WebAuthenticationBroker on UWP * Make code more readable * iOS10+ is only supported so remove check * Move last fallback into TVOS * Remove unnecessary duplicate attribute * Change exception type. * Better error message * Make AppleSignIn accessible from shared code * Added sample aspnet project for auth * Apple Signin for iOS only for now * Make auth sample use sample server * Added some tests * Make some methods private that shouldn't be public * Add docs * Increase device test timeout * Add human interaction traits to some new tests * Update devicetests cake Updated to newer addins Stop using cake bootstrappers * Run device tests with cake dotnet core * Bump xunit device runner * Tests go back to netcore 2 * Bump xunit device runner in rest of devicetest projs * Build that android app first! * Cleanup web auth - Change result type name - Clean up result type properties - Remove IsSupported from apple public api - Throw not supported in public apple api on < iOS 13 * Update sample to check for iOS 13 independently * Update docs * Make code a bit more readable. * More readable code changes * Fix test * Add some detection of callback activity This adds some code to ensure the developer has subclassed `WebAuthenticatorCallbackActivity` and registered an appropriate intentfilter for it based on the `callbackUrl` being used. Co-authored-by: James Montemagno <james.montemagno@gmail.com> * Use iOS 13.3 :) (#1089) * Rename apple signin options (#1094) * Rename type * Fix docs * Android setup Script (#1086) * Add Android setup script Installs everything you need for development :) * Update README.md * Update README.md * This double is not in the interning list of double, so this will allocate less. Verified in Benchmark.Net (#1097) * Try catch getting Network Adapter and only query it once. Log if there is an issue. (#1088) Co-authored-by: Jonathan Dick <jondick@gmail.com> * Cache device type and name (#1087) Co-authored-by: Jonathan Dick <jondick@gmail.com> * AndroidX (#1095) * Use AndroidX references for Android 10+ * Directly use AndroidX api's on API 29 + * Bump sample/device tests to api 29 * Migrate resource files in device tests / sample to androidx * Fix nuget references * Fix test with api 29 deprecations * Go STABLE!!! * Drop Android 6.0-7.1 as targets This is just the compile targets, it still runs all the way to 4.4 - and probably earlier Co-authored-by: Matthew Leibowitz <mattleibow@live.com> * four more minor changes (#1101) * This double is not in the interning list of double, so this will allocate less. Verified in Benchmark.Net * Should both be readonly * I reused the branch so I need to remove this for merging * type should be static, features should be unique. more efficient Co-authored-by: Jonathan Dick <jondick@gmail.com> * Launch adjacent flag on Android 24+ (#1074) * Launch adjacent! <3 Dou It! * refactor code * not share * 1.5.0 Changes (#1124) * Implement vertical accuracy in GeoLocation API (#1103) * Location: add property 'VerticalAccuracy' (#1099) * vertical accuracy is only available in Android API level 26 and above (#1099) * update Samples app to show vertical accuracy on GeolocationPage * add missing documentation bits for Location.VerticalAccuracy * .gitattributes: get better diff context for C# code (#1115) * Location.VerticalAccuracy: add runtime check for Android version (#1099) (#1116) * the compile-time check is not enough * it crashed on old Android versions (<8.0) * GH-1102 Fix launcher on older devices (#1120) * Update Launcher.ios.tvos.cs * OpenUrlAsync was introduced in iOS 10 not 12 https://docs.microsoft.com/en-us/dotnet/api/uikit.uiapplication.openurlasync?view=xamarin-ios-sdk-12 * Fix trailing whitespace * Really? fix whitespace * Really! Fix whitespace Co-authored-by: Janus Weil <janus@gcc.gnu.org> Co-authored-by: James Montemagno <james.montemagno@gmail.com> Co-authored-by: James Montemagno <james.montemagno@gmail.com> Co-authored-by: Niklas Schilli <schillinik@yahoo.de> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Janus Weil <janus@gcc.gnu.org>

* Implement vertical accuracy in GeoLocation API (#1103) * Location: add property 'VerticalAccuracy' (#1099) * vertical accuracy is only available in Android API level 26 and above (#1099) * update Samples app to show vertical accuracy on GeolocationPage * add missing documentation bits for Location.VerticalAccuracy * .gitattributes: get better diff context for C# code (#1115) * Location.VerticalAccuracy: add runtime check for Android version (#1099) (#1116) * the compile-time check is not enough * it crashed on old Android versions (<8.0) * GH-1102 Fix launcher on older devices (#1120) * Update Launcher.ios.tvos.cs * OpenUrlAsync was introduced in iOS 10 not 12 https://docs.microsoft.com/en-us/dotnet/api/uikit.uiapplication.openurlasync?view=xamarin-ios-sdk-12 * Fix trailing whitespace * Really? fix whitespace * Really! Fix whitespace * Fixes #1129 - set empty required declarations on UWP (#1133) * Fixes #1129 - set empty required declarations on UWP * Update Permissions.uwp.cs * Update Xamarin.Essentials.csproj (#1136) * GH-1142 AccessBackgroundLocation only when compile & running Q (#1143) * AccessBackgroundLocation only when compile & running Q * put if compile check around permission * GH-1121 If VC is null use TraitCollection (#1144) * Fixes #1123 (#1126) * Update PlacemarkExtensions.xml (#1132) Co-authored-by: Janus Weil <janus@gcc.gnu.org> Co-authored-by: James Montemagno <james.montemagno@gmail.com> Co-authored-by: Michael <Michael@ZPF.fr>

* Implement vertical accuracy in GeoLocation API (#1103) * Location: add property 'VerticalAccuracy' (#1099) * vertical accuracy is only available in Android API level 26 and above (#1099) * update Samples app to show vertical accuracy on GeolocationPage * add missing documentation bits for Location.VerticalAccuracy * .gitattributes: get better diff context for C# code (#1115) * Location.VerticalAccuracy: add runtime check for Android version (#1099) (#1116) * the compile-time check is not enough * it crashed on old Android versions (<8.0) * GH-1102 Fix launcher on older devices (#1120) * Update Launcher.ios.tvos.cs * OpenUrlAsync was introduced in iOS 10 not 12 https://docs.microsoft.com/en-us/dotnet/api/uikit.uiapplication.openurlasync?view=xamarin-ios-sdk-12 * Fix trailing whitespace * Really? fix whitespace * Really! Fix whitespace * Fixes #1129 - set empty required declarations on UWP (#1133) * Fixes #1129 - set empty required declarations on UWP * Update Permissions.uwp.cs * Update Xamarin.Essentials.csproj (#1136) * GH-1142 AccessBackgroundLocation only when compile & running Q (#1143) * AccessBackgroundLocation only when compile & running Q * put if compile check around permission * GH-1121 If VC is null use TraitCollection (#1144) * Fixes #1123 (#1126) * Update PlacemarkExtensions.xml (#1132) Co-authored-by: Janus Weil <janus@gcc.gnu.org> Co-authored-by: James Montemagno <james.montemagno@gmail.com> Co-authored-by: Michael <Michael@ZPF.fr> Co-authored-by: Jonathan Dick <jodick@microsoft.com> Co-authored-by: Janus Weil <janus@gcc.gnu.org> Co-authored-by: Michael <Michael@ZPF.fr>

janusw added 4 commits February 18, 2020 10:17

Location: add property 'VerticalAccuracy' (xamarin#1099)

f18e17c

vertical accuracy is only available in Android API level 26 and above (…

d991b8a

…xamarin#1099)

update Samples app to show vertical accuracy on GeolocationPage

2b874a6

add missing documentation bits for Location.VerticalAccuracy

e1ec33f

janusw requested review from jamesmontemagno, Redth and mattleibow February 18, 2020 20:23

Redth changed the base branch from master to develop February 21, 2020 17:34

Redth approved these changes Feb 21, 2020

View reviewed changes

Redth merged commit f13c66c into xamarin:develop Feb 23, 2020

janusw deleted the issue1099_location_vertical_accuracy branch February 23, 2020 20:11

jamesmontemagno added this to the 1.5.1 milestone Mar 3, 2020

jamesmontemagno mentioned this pull request Mar 6, 2020

1.5.1 (#1145) -> Merge into develop #1154

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement vertical accuracy in GeoLocation API #1103

Implement vertical accuracy in GeoLocation API #1103

Uh oh!

janusw commented Feb 18, 2020

Uh oh!

Redth commented Feb 19, 2020

Uh oh!

janusw commented Feb 19, 2020

Uh oh!

janusw commented Feb 23, 2020

Uh oh!

Redth commented Feb 23, 2020

Uh oh!

janusw commented Feb 23, 2020

Uh oh!

Uh oh!

Implement vertical accuracy in GeoLocation API #1103

Implement vertical accuracy in GeoLocation API #1103

Uh oh!

Conversation

janusw commented Feb 18, 2020

Description of Change

Bugs Fixed

API Changes

Behavioral Changes

PR Checklist

Uh oh!

Redth commented Feb 19, 2020

Uh oh!

janusw commented Feb 19, 2020

Uh oh!

janusw commented Feb 23, 2020

Uh oh!

Redth commented Feb 23, 2020

Uh oh!

janusw commented Feb 23, 2020

Uh oh!

Uh oh!