This repository was archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a manual merge of #30
The merge.targets will get merged into the generated .targets file for a given nuget package. This was being gitignored and not properly making it in. This target helps us check the version of android tools installed and adds the —no-version-vectors flag to aapt calls.
This is only needed for app compilation (so that javac can reference the annotations when compiling), not needed in the actual app.
This fixes bindings so they compile with 25.3.1
We want to start tracking specific cases where we identify issues and try to build some tests around them to avoid future regressions. This android app will serve as a solution that can be run to perform these tests. Currently it will need to be run manually.
Default is still release, but now we can build in Debug mode with an arg.
There were some initial optimizations done to the adding of —no-version-vectors to AndroidResgenExtraArgs, but they were made to the wrong file. The build script caused the modified file to be overwritten during the build making the changes ineffective. This commit cleans up where the .targets file lives so the build tasks project reads it from one source, and the build script no longer copies the file around.
The build task’s targets will already be merged in the root level generated.targets
The build task’s targets will already be merged in the root level generated.targets
This class proves to be useful based on some internal feedback, so bringing it back into the binding.
This is the new unifying package which all others depend on in support so that there are no javac errors during app compile due to missing referenced annotations. This also acts as a version locking unification package for all of support libs, so it should no longer be possible to get versions out of sync (eg: previously you could install a different version of CardView).
Previously the nuspec was changed to use the merge.targets which was incorrect. That file gets merged into the template produced targets to generate Xamarin.Android.Support.Vector.Drawable.targets which is what needs to be packaged into the nuget.
Constraint Layout v1.0.0-beta5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates support library bindings to v25.3.1