Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Conversation

@Redth
Copy link
Member

@Redth Redth commented Apr 3, 2017

Updates support library bindings to v25.3.1

Redth added 24 commits February 27, 2017 15:12
This is a manual merge of #30
The merge.targets will get merged into the generated .targets file for a given nuget package.  This was being gitignored and not properly making it in.  This target helps us check the version of android tools installed and adds the —no-version-vectors flag to aapt calls.
This is only needed for app compilation (so that javac can reference the annotations when compiling), not needed in the actual app.
This fixes bindings so they compile with 25.3.1
We want to start tracking specific cases where we identify issues and try to build some tests around them to avoid future regressions.

This android app will serve as a solution that can be run to perform these tests.  Currently it will need to be run manually.
Default is still release, but now we can build in Debug mode with an arg.
Redth added 5 commits April 3, 2017 16:40
There were some initial optimizations done to the adding of —no-version-vectors to AndroidResgenExtraArgs, but they were made to the wrong file.  The build script caused the modified file to be overwritten during the build making the changes ineffective.

This commit cleans up where the .targets file lives so the build tasks project reads it from one source, and the build script no longer copies the file around.
The build task’s targets will already be merged in the root level generated.targets
The build task’s targets will already be merged in the root level generated.targets
This class proves to be useful based on some internal feedback, so bringing it back into the binding.
Redth added 8 commits April 6, 2017 16:32
This is the new unifying package which all others depend on in support so that there are no javac errors during app compile due to missing referenced annotations.

This also acts as a version locking unification package for all of support libs, so it should no longer be possible to get versions out of sync (eg: previously you could install a different version of CardView).
Previously the nuspec was changed to use the merge.targets which was incorrect.  That file gets merged into the template produced targets to generate Xamarin.Android.Support.Vector.Drawable.targets which is what needs to be packaged into the nuget.
@Redth Redth merged commit aa6ce5b into master Apr 27, 2017
@Redth Redth deleted the v25.3.1 branch April 27, 2017 00:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants