This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Added binding for ActionMenuView SetPresenter to Additions. #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sizeak, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@Redth I'm not sure who to tag, but you seem to have done the most recent contributions. Can you or someone else take a look at this please? Thanks. |
|
@Redth Any chance of getting this looked at? I'm having to maintain my own build currently. |
|
Thanks, I've manually merged this into the latest version branch we are working on: |
|
Excellent, thanks very much!
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10
From: Jonathan Dick<mailto:notifications@github.com>
Sent: 18 April 2017 15:30
To: xamarin/AndroidSupportComponents<mailto:AndroidSupportComponents@noreply.github.com>
Cc: Simon Jackson<mailto:sizeak@hotmail.com>; Mention<mailto:mention@noreply.github.com>
Subject: Re: [xamarin/AndroidSupportComponents] Added binding for ActionMenuView SetPresenter to Additions. (#30)
Thanks, I've manually merged this into the latest version branch we are working on:
https://github.com/xamarin/AndroidSupportComponents/blob/v25.3.1/v7-appcompat/source/Additions/ActionMenuView.cs
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#30 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AASYHOue0qC43yZ_WrW9ex08v03odnGyks5rxMjNgaJpZM4LH0LL>.
|
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Libraries Version (eg: 23.3.0):
Latest
Does this change any of the generated binding API's?
Yes
Describe your contribution
No binding was generated for the setPresenter method of the ActionMenuView class, despite it appearing in api.xml. This change uses the additions system to add the method manually.