Switch to vanilla rubocop #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 2.5.8 has been dropped from the officially-supported versions list and will no longer make up part of the testing matrix, but it will probably continue to work and be unofficially supported.
This is an experimental switch from the GOV.UK rubocop config to the vanilla one as part of the Ruby 3.0.0 upgrade. Seeing as many of the less-useful cops are already ignored and this has pointed out some improvements to the codebase it feels like a reasonable step.
|
This is too big a leap, let's stick with the GOV.UK variant for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an experiment - it follows on from #232
Switch from the GOV.UK rubocop config to the vanilla one as part of the Ruby 3.0.0 upgrade. Seeing as many of the
less-useful cops are already ignored and this has pointed out some improvements to the codebase it feels like a reasonable step.
Leaving here for discussion closer to the time when we're ready to make the jump to supporting 3.0.0.