Skip to content

Update protobuf-java to 4.33.2 #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xerial-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update protobuf-java to 4.33.2 #4106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,7 +948,7 @@ lazy val benchmark =
// "com.thesamet.scalapb" %% "scalapb-runtime-grpc" % scalapb.compiler.Version.scalapbVersion
// For grpc-java
"io.grpc" % "grpc-protobuf" % GRPC_VERSION,
"com.google.protobuf" % "protobuf-java" % "3.25.8",
"com.google.protobuf" % "protobuf-java" % "4.33.2",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This update to protobuf-java version 4.33.2 is a major version bump from 3.x and is likely to cause binary incompatibility issues at runtime.

The benchmark module also depends on io.grpc:grpc-protobuf:${GRPC_VERSION} (where GRPC_VERSION is 1.77.0). The grpc-protobuf:1.77.0 library transitively depends on protobuf-java:3.25.3.

  • ABI Incompatibility: According to the Protocol Buffers documentation, the 4.x release series is not Application Binary Interface (ABI) compatible with the 3.x series.
  • Runtime Errors: Libraries compiled against protobuf-java:3.x (like grpc-protobuf:1.77.0) will not work correctly with protobuf-java:4.x and will likely fail at runtime with errors such as NoSuchMethodError or AbstractMethodError.

To resolve this, you should keep protobuf-java on a 3.x version to maintain compatibility with grpc-java:1.77.0. I recommend reverting this change.

Given this is an automated dependency update from Scala Steward, it might have incorrectly suggested this major version upgrade. It would be safer to stick to the 3.x line for protobuf-java.

        "com.google.protobuf" % "protobuf-java" % "3.25.8",

("com.chatwork" %% "scala-ulid" % "1.0.24").cross(CrossVersion.for3Use2_13)
)
// Compile / PB.targets := Seq(
Expand Down
Loading