-
Notifications
You must be signed in to change notification settings - Fork 71
Update protobuf-java to 4.33.2 #4106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine dependency update, specifically upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates protobuf-java from version 3.25.8 to 4.33.2. This is a major version upgrade that is likely to cause binary incompatibilities with other dependencies, specifically grpc-protobuf. I've left a comment with details on the potential issue and a suggestion to revert this change to maintain compatibility.
| // For grpc-java | ||
| "io.grpc" % "grpc-protobuf" % GRPC_VERSION, | ||
| "com.google.protobuf" % "protobuf-java" % "3.25.8", | ||
| "com.google.protobuf" % "protobuf-java" % "4.33.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update to protobuf-java version 4.33.2 is a major version bump from 3.x and is likely to cause binary incompatibility issues at runtime.
The benchmark module also depends on io.grpc:grpc-protobuf:${GRPC_VERSION} (where GRPC_VERSION is 1.77.0). The grpc-protobuf:1.77.0 library transitively depends on protobuf-java:3.25.3.
- ABI Incompatibility: According to the Protocol Buffers documentation, the
4.xrelease series is not Application Binary Interface (ABI) compatible with the3.xseries. - Runtime Errors: Libraries compiled against
protobuf-java:3.x(likegrpc-protobuf:1.77.0) will not work correctly withprotobuf-java:4.xand will likely fail at runtime with errors such asNoSuchMethodErrororAbstractMethodError.
To resolve this, you should keep protobuf-java on a 3.x version to maintain compatibility with grpc-java:1.77.0. I recommend reverting this change.
Given this is an automated dependency update from Scala Steward, it might have incorrectly suggested this major version upgrade. It would be safer to stick to the 3.x line for protobuf-java.
"com.google.protobuf" % "protobuf-java" % "3.25.8",
About this PR
📦 Updates com.google.protobuf:protobuf-java from
3.25.8to4.33.2⚠Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: