Skip to content

Conversation

@ysmolski
Copy link
Contributor

@ysmolski ysmolski commented Sep 25, 2025

This index does not mean anything to the user, so we better remove it.

Summary by CodeRabbit

  • Chores
    • Updated core GraphQL tooling dependency to the latest release candidate for improved compatibility and stability.
  • Tests
    • Adjusted integration test expectations for error path reporting to align with upstream changes; no impact on runtime behavior or user-facing functionality.

This index does not mean anything to the user, so we better remove it.
@coderabbitai
Copy link

coderabbitai bot commented Sep 25, 2025

Walkthrough

Bumped github.com/wundergraph/graphql-go-tools/v2 from v2.0.0-rc.228 to v2.0.0-rc.229 in router and router-tests modules. Updated a test’s expected error path in router-tests/integration_test.go.

Changes

Cohort / File(s) Summary
Dependency bump (graphql-go-tools)
router/go.mod, router-tests/go.mod
Update dependency github.com/wundergraph/graphql-go-tools/v2 from v2.0.0-rc.228 to v2.0.0-rc.229.
Test expectation update
router-tests/integration_test.go
Adjust expected error extensions.path from ["products","@","lead","0","isAvailable"] to ["products","@","lead","isAvailable"].

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title succinctly describes the main change by indicating the removal of an unnecessary index after “_entities” in error paths, directly reflecting the described update and adhering to the Conventional Commits style.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate Docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Sep 25, 2025

Router-nonroot image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-21fc8dd72082862958de7e8fdc735e654ea25d7e-nonroot

@ysmolski ysmolski merged commit ad1818e into main Sep 25, 2025
30 checks passed
@ysmolski ysmolski deleted the yury/eng-8215-empty-path-in-error-response-for-query branch September 25, 2025 13:57
@Noroth Noroth mentioned this pull request Sep 30, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants