fix: only fail CI when transfer permissions are missing #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normal drift (missing repos, description/topic differences) will be fixed on merge, so CI should not block those. Pending transfers with admin permissions are ready to proceed once transfer automation is implemented. Only block CI when a transfer is requested but worlddriven lacks admin access to the source repository - this requires manual intervention.
Contributor
🤖 Worlddriven Status📊 Live Status Dashboard🗓️ Merge Date: 2025-12-01 at 22:37:35 UTC (today) 🎯 Want to influence when this merges?Your review matters! As a contributor to this project, your voice helps determine the merge timeline. How to review:
Your options:
💡 Pro tip: The more contributors who agree, the faster this gets merged! 📊 View detailed stats on the dashboard 📋 Recent Activity• 2025-11-30, 06:37:43 - Pull request opened This comment is automatically updated by worlddriven |
TooAngel
added a commit
to TooAngel/worlddriven-documentation
that referenced
this pull request
Dec 4, 2025
The previous fix (PR worlddriven#14) updated detect-drift.js to exit with code 1 when transfers are blocked due to missing permissions, but the workflow file was never updated to propagate that failure. The workflow had `exit 0` which always passed the job regardless of the script's exit code. Changed to `exit 1` so the CI properly fails when worlddriven lacks admin permission on source repositories.
TooAngel
added a commit
to TooAngel/worlddriven-documentation
that referenced
this pull request
Dec 4, 2025
The previous fix (PR worlddriven#14) updated detect-drift.js to exit with code 1 when transfers are blocked due to missing permissions, but the workflow file was never updated to propagate that failure. The workflow had `exit 0` which always passed the job regardless of the script's exit code. Changed to `exit 1` so the CI properly fails when worlddriven lacks admin permission on source repositories.
worlddriven bot
pushed a commit
that referenced
this pull request
Dec 6, 2025
The previous fix (PR #14) updated detect-drift.js to exit with code 1 when transfers are blocked due to missing permissions, but the workflow file was never updated to propagate that failure. The workflow had `exit 0` which always passed the job regardless of the script's exit code. Changed to `exit 1` so the CI properly fails when worlddriven lacks admin permission on source repositories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows PR #12 (core migration) to pass CI since worlddriven has admin access to TooAngel/worlddriven.
Related: #12, #13