fix: make drift detection fail when transfer automation is not ready

[TooAngel]

Problem

Currently, the drift detection CI passes when repositories with Origin field are added to REPOSITORIES.md, even though:

• The repository doesn't exist in the org yet
• The transfer automation is not implemented
• The PR can't actually be executed successfully

This is misleading because the CI shows green but the PR represents actual drift that should block merging.

Root Cause

In scripts/detect-drift.js, the hasDrift calculation excluded pendingTransfer:

// Note: pendingTransfer is informational, not an error
const hasDrift = drift.missing.length > 0 ||
                 drift.extra.length > 0 ||
                 drift.descriptionDiff.length > 0 ||
                 drift.topicsDiff.length > 0;
// pendingTransfer was NOT included!

Repositories with Origin field were added to drift.pendingTransfer and then skipped all other checks (including the "missing" check), so they never caused the CI to fail.

Solution

Update the drift detection logic to:

1. Include pendingTransfer in hasDrift calculation - Causes CI to fail when transfer automation is not ready
2. Update messaging - Change from warning (⚠️) to error (❌) to reflect blocking behavior
3. Clarify comments - Update code comments to reflect that pending transfers now block CI

Changes

// Exit with error code if drift detected (useful for CI)
// Note: pendingTransfer blocks CI until transfer automation is implemented
const hasDrift = drift.missing.length > 0 ||
                 drift.extra.length > 0 ||
                 drift.descriptionDiff.length > 0 ||
                 drift.topicsDiff.length > 0 ||
                 drift.pendingTransfer.length > 0;  // <-- Added

// Warn about pending transfers (causes CI to fail)
if (drift.pendingTransfer.length > 0) {
  console.error('\n❌ Error: Repository transfer feature is under development');  // ⚠️ -> ❌
  console.error('   This PR will be blocked until transfer automation is complete');

Impact

After this fix:

• ✅ PRs with Origin field will fail CI until transfer automation is complete
• ✅ Clear error messaging explains why the PR is blocked
• ✅ Prevents misleading "green CI" when PRs can't actually be executed
• ✅ Aligns with existing documentation that says "PRs with Origin field will be blocked"

Testing

This fix can be tested with PR #12 which adds a repository with Origin field:

• Before this fix: CI passes (incorrect)
• After this fix: CI should fail with clear error message (correct)

Related

• Issue feat: implement repository transfer automation for migration to worlddriven org #9 - Repository transfer automation implementation
• PR feat: implement permission verification for repository transfers #11 - Permission verification (partial implementation)
• PR feat: add worlddriven core repository for migration #12 - First migration attempt (will demonstrate this fix)

[worlddriven]

🤖 Worlddriven Status

📊 Live Status Dashboard

🗓️ Merge Date: 2025-11-29 at 16:19:45 UTC (today)
📅 Started: 2025-11-27 at 20:41:35 UTC
⚡ Speed Factor: 0.18 (82% faster due to reviews)
✅ Positive votes: 9/11 contribution weight (coefficient: 0.82)
📈 Base Merge Time: 10 days → Current: 2 days

🎯 Want to influence when this merges?

Your review matters! As a contributor to this project, your voice helps determine the merge timeline.

How to review:

1. Check the changes
   

2. Leave your review
   

Your options:

• ✅ Agree & Speed Up: Approving makes this merge faster
• ❌ Disagree & Slow Down: Requesting changes delays the merge

💡 Pro tip: The more contributors who agree, the faster this gets merged!

📊 View detailed stats on the dashboard

📋 Recent Activity

• 2025-11-27, 20:41:42 - Pull request opened
• 2025-11-27, 20:41:44 - Pull request opened
• 2025-11-29, 16:51:53 - Pull request merged by worlddriven ✅

---

This comment is automatically updated by worlddriven