-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More block enhancements #1079
More block enhancements #1079
Conversation
Nice work! A couple of little things I wanted to document – although not specific to the Read More block (also applies to the Page Break block):
|
Thank you for the review @iamthomasbishop !
I was able to extend the lines a bit more, until the edge of the block content. We can extend them more using some negative magic margin values, but I'm not sure if that's what you had in mind, and it might not be a very good idea :)
✅
The lines are actually a normal (thin) view with a background color. Not possible to make them dashed with the current component we are using. I'd recommend this to be a future enhancement. This is an updated screenshot: |
For reference, some initial effort going (on hold) here: WordPress/gutenberg#14175 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If @iamthomasbishop is good with the visuals, the implementation looks good to me
Looks great to me! Thanks for the updates @etoledom! |
Thank you both! |
Fixes #859
As mentioned in #859 (comment), I opted for modifying the More block to be read only, in order for it to be ready for the next release.
More info and test steps on the gutenberg side PR: WordPress/gutenberg#16005
On the design side, I noticed on web that More block and Page Break block look the same, so I implemented the same design we use for Page Break on mobile too, but I'll wait for @iamthomasbishop 's input on this.
Update release notes:
RELEASE-NOTES.txt
.