-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Modified More block to be read-only #16005
Conversation
c8ff1e2
to
797c3c7
Compare
onBlur={ onBlur } | ||
<View | ||
accessible={ ! this.props.isSelected } | ||
accessibilityLabel={ __( 'More block' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be "Read more block"? More feels a bit ambiguous
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified the accessibility config based on wordpress-mobile/gutenberg-mobile#937
Now all blocks will have a default label based on the gutenberg-defined block name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking 😍 to me
Thank you! |
gutenberg-mobile side PR: wordpress-mobile/gutenberg-mobile#1079
As mentioned in wordpress-mobile/gutenberg-mobile#859 (comment), I opted for modifying the
More
block to be read only, in order for it to be ready for the next release.I did a fast test using RichText. It does work well on iOS, but it had some alignment issues on Android, that would need native code to be fixed. It also had a visual glitch on split.
Fixing those issues on Android, it looks promising to use RichText to make this component editable.
Alternatively, we might also want to think on a simpler PlaneText component that we can manipulate at the native level for these cases.
On the design side, I noticed on web that More block and Page Break block look the same, so I implemented the same design we use for Page Break on mobile too.
To test: