This repository was archived by the owner on Sep 4, 2018. It is now read-only.
Improve framework support #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets header_dir to WordPressComAnalytics to avoid problems with underscores/dashes in names. I'd bump the minor version since this breaks backwards compatibility, but I'm not sure what to do since it's 0.0
This was referenced Nov 10, 2015
Member
Author
|
Merged develop, ready for review |
Member
Author
|
Found an issue with bundles and the data model, don't merge yet |
Member
Author
|
Never mind, I keep confusing Analytics with Tracks, problem is with a different pod 😫 |
Contributor
|
Whoops, sorry @koke I forgot the iOS side prefers to merge in themselves. Looked great though |
This was referenced Nov 13, 2015
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets header_dir to WordPressComAnalytics to avoid problems with
underscores/dashes in names.
I'd bump the minor version since this breaks backwards compatibility,
but I'm not sure what to do since it's 0.0
See wordpress-mobile/WordPress-iOS#4434
Needs Review: @kwonye