This repository was archived by the owner on Dec 13, 2017. It is now read-only.
Cocoapods framework support #738
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets header_dir to WordPressEditor to avoid problems with underscores/dashes in names. I bumped the version to 1.1 because this changes how you import headers from this pod. Updated WordPressShared and WordPressComAnalytics imports.
Member
Author
|
Closing this one since it's easier to reapply changes than to fix conflicts. I'll re-submit soon |
Contributor
|
Thanks @koke. I needed to make sure all the 5.8 changes got merged in first. Sorry for the trouble. :-) |
Member
Author
|
No problem, thanks to this I just noticed I missed a couple things in the legacy editor :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets header_dir to WordPressEditor to avoid problems with
underscores/dashes in names. I bumped the version to 1.1 because this
changes how you import headers from this pod.
Updated WordPressShared and WordPressComAnalytics imports.
As I bumped version, it'll need to be released after merging
See wordpress-mobile/WordPress-iOS#4434
Needs Review: @bummytime