Skip to content

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Jan 4, 2023

See conversation at https://github.com/wordpress-mobile/WordPress-iOS/pull/19793/files#r1052892161

To test

This change does not affect either the codebase or the automation. Green CI will suffice.

Regression Notes

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

@mokagio mokagio self-assigned this Jan 4, 2023
@mokagio mokagio added the Tooling Build, Release, and Validation Tools label Jan 4, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 4, 2023

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19834-a5cffbf on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 4, 2023

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19834-a5cffbf on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@mokagio mokagio force-pushed the mokagio/add-xcode-version-note branch from 8c328b3 to a1fc99f Compare January 5, 2023 02:14
@mokagio mokagio force-pushed the mokagio/add-xcode-version-note branch from a1fc99f to a5cffbf Compare January 5, 2023 03:46
@mokagio mokagio marked this pull request as ready for review January 18, 2023 03:42
@mokagio mokagio mentioned this pull request Jan 18, 2023
4 tasks
@mokagio mokagio enabled auto-merge January 18, 2023 03:44
XCODE_SCHEME = 'WordPress'
XCODE_CONFIGURATION = 'Debug'
EXPECTED_XCODE_VERSION = File.read('.xcversion').rstrip
EXPECTED_XCODE_VERSION = File.read('.xcode-version').rstrip
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.xcode-version is the recommended name for the file

@mokagio mokagio merged commit 69ccc50 into trunk Jan 18, 2023
@mokagio mokagio deleted the mokagio/add-xcode-version-note branch January 18, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tooling Build, Release, and Validation Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants