Use Xcode 14.2 on CI #19793
Merged
Use Xcode 14.2 on CI #19793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
Contributor
You can test the changes in WordPress from this Pull Request by:
|
spencertransier
approved these changes
Dec 20, 2022
Contributor
spencertransier
left a comment
spencertransier
left a comment
There was a problem hiding this comment.
Approved so you're not blocked, but I was curious about upping the .xcversion and how that is used in case there are implications for developers.
| @@ -1 +1 @@ | |||
| 13.4.1 | |||
| 14.2 | |||
Contributor
There was a problem hiding this comment.
Do we also increase this version each time we update the CI image in the pipelines? I'm not familiar with how we use .xcversion, so I wasn't sure.
Contributor
Author
There was a problem hiding this comment.
I wasn't sure either 🥲 . But we probably should apply the same changes in this Woo iOS PR to this repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What says in the title.
Test instructions
CI checks should be enough. Nothing else I can think of.
Regression Notes
Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
None.
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txtif necessary.