-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Jetpack Focus: Implements actions inside the Jetpack menu card #19785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…presenter instances
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
momo-ozawa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described! LGTM w 1 comment
|
|
||
| enum Strings { | ||
| static let phaseThreeDescription = NSLocalizedString("jetpack.menuCard.description", | ||
| value: "Stats, Reader, Notifications and other features will soon move to the Jetpack mobile app.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| value: "Stats, Reader, Notifications and other features will soon move to the Jetpack mobile app.", | |
| value: "Stats, Reader, Notifications and other features will move to the Jetpack mobile app soon.", |
[imo] This sounds a bit better - we could check in with the editorial team if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree!
Part of #19450
Description
This PR builds on #19782 and implements the following missing actions:
Screenshots
Testing Instructions
Display the fullscreen overlay
Hiding the card
JetpackBrandingMenuCardPresenter.swiftline 90secondsInDayto any small value, 10, for examplesecondsInDayto 10, then wait for 70 seconds)secondsInDayto 10, then wait for 70 seconds)Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.