Skip to content

Conversation

@hassaanelgarem
Copy link
Contributor

@hassaanelgarem hassaanelgarem commented Dec 16, 2022

Part of #19450

Description

This PR builds on #19782 and implements the following missing actions:

  • Tapping the card should open up an overlay
  • Tapping the ellipsis button and then tapping "Remind me later" should hide the card for 4 days.
  • Tapping the ellipsis button and then tapping "Hide this" should hide the card indefinitely.

Screenshots

Light Mode Dark Mode
light dark

Testing Instructions

Display the fullscreen overlay

  1. Make sure that only the "Jetpack Features Removal Phase Three" flag is enabled from the debug menu
  2. Kill the app
  3. Launch the app
  4. Make sure the menu card is displayed
  5. Tap anywhere on the card
  6. Make sure the overlay is displayed
  7. Make sure the overlay matches the design

Hiding the card

  1. Go to JetpackBrandingMenuCardPresenter.swift line 90
  2. Change the value of secondsInDay to any small value, 10, for example
  3. Make sure that only the "Jetpack Features Removal Phase Three" flag is enabled from the debug menu
  4. Kill the app
  5. Launch the app
  6. Make sure the menu card is displayed
  7. Tap on the ellipsis button and then tap "Remind me later"
  8. Make sure the card is hidden
  9. Kill and relaunch the app
  10. Make sure the menu card is still not showing
  11. Wait for the duration to pass (If you set secondsInDay to 10, then wait for 70 seconds)
  12. Kill and relaunch the app
  13. Make sure the menu card is displayed
  14. Tap on the ellipsis button and then tap "Hide this"
  15. Make sure the card is hidden
  16. Wait for the duration to pass (If you set secondsInDay to 10, then wait for 70 seconds)
  17. Kill and relaunch the app
  18. Make sure the menu card is not showing

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 16, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19785-c7bfa99 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 16, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19785-c7bfa99 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Base automatically changed from task/19450-phase-3-card to trunk December 18, 2022 12:57
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described! LGTM w 1 comment


enum Strings {
static let phaseThreeDescription = NSLocalizedString("jetpack.menuCard.description",
value: "Stats, Reader, Notifications and other features will soon move to the Jetpack mobile app.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value: "Stats, Reader, Notifications and other features will soon move to the Jetpack mobile app.",
value: "Stats, Reader, Notifications and other features will move to the Jetpack mobile app soon.",

[imo] This sounds a bit better - we could check in with the editorial team if needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree!

@hassaanelgarem hassaanelgarem merged commit 6011ff8 into trunk Dec 19, 2022
@hassaanelgarem hassaanelgarem deleted the task/19450-phase-3-card-actions branch December 19, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants