Add RN patch for RCTShadowView.m to prevent crash in nested group block#13310
Merged
Add RN patch for RCTShadowView.m to prevent crash in nested group block#13310
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
Contributor
|
Tested manually in WordPress-iOS app - nested 5 groups:
No crash, works as expected 🎉 |
lukewalczak
approved these changes
Jan 29, 2020
pinarol
approved these changes
Jan 29, 2020
pull bot
pushed a commit
to scope-demo/WordPress-iOS
that referenced
this pull request
Jan 29, 2020
…ck (wordpress-mobile#13310) * test patch * update podfile.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#1747
There is an issue on iOS with nested views.
This is fixed here facebook/react-native#26986
It's merged to master and will land in 0.62 version of
react-native, however it is a blocker for us since we can not nest more than 3 group blocks because of that. We could cherry-pick this commit to our fork but as I can see we do not use our fork anymore.To fix that on our side we used a patch mechanism. The mechanism is very simple. I created a patch that is in the
patchesdirectory and contains my changes. The patch is applied inpost_installhook of cocoapods.To test:
install dependencies
run app and open gutenberg editor
add at least 4 nested group blocks
the app shouldn't crash
I have considered adding unit tests where possible.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.