[iOS] Remove max depth parameter while measuring layout of shadow view#26986
Closed
dratwas wants to merge 1 commit intofacebook:masterfrom
Closed
[iOS] Remove max depth parameter while measuring layout of shadow view#26986dratwas wants to merge 1 commit intofacebook:masterfrom
dratwas wants to merge 1 commit intofacebook:masterfrom
Conversation
facebook-github-bot
added
CLA Signed
facebook-github-bot
approved these changes
Oct 28, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @dratwas in 2f8328d. When will my fix make it into a release? | Upcoming Releases |
This was referenced Jan 6, 2020
2 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Searching for the ancestor view while measuring a shadow view layout relative to the ancestor is limited to
30. I couldn't find the reason nor commit where it was introduced (because I have no access to internal facebook commits).I think we should keep looking for an ancestor view until the shadow view has the superview property.
Changelog
[iOS] [Fixed] - Remove maximum searching depth while measuring layout.
Test Plan