Site Settings final pass - design, analytics, feature toggling

[tonyr59h]

This PR will cover #3434, #3441, and #3477.

Not ready for developer review, opening this for @mattmiklic to verify that the design is correct and to visualize the diff for myself.

Edit:
All the issues should be covered now, ready for review!

[aforcier]

Following our conversation, I gave the number picker a quick test on an API 18 Samsung S3 to check for OEM landmines on their part (since reflection was used for styling and the internals may have been changed).

Everything seems to work, no crashes. 👍

There's only a border issue that's likely API-level related and not specific to the Samsung:

[mattmiklic]

It's looking good now; most of my comments are fairly minor at this point. Roughly in order of importance:

On all dialogs that include just a text input (site title, tagline, adding items to the moderation/blacklist, etc.); when the dialog appears the input is focused but the keyboard isn't visible; you have to tap the input to bring up the keyboard. Could we show the keyboard automatically?

On the Hold for Moderation and Blacklist screens, if I select two or more items and tap the Delete icon, only one item is deleted.

On screens where we include a picker, ideally the borders will appear directly above and below the picker, separating it from any other text or header in the dialog. Here are two examples (these screens also have a few font issues I have noted in red):

The Discussion settings screen has a few items that are in Roboto instead of Open Sans, and the border color is off.

[mattmiklic]

I just noticed one bigger issue; "Close after" is missing the toggle switch to turn that setting on or off.

[tonyr59h]

Recent commits address all of Matt's comments. @kwonye ready for another go.

[daniloercoli]

Getting an issue with Default Category. The modal could be empty under some circumstances (slow network connection):

[daniloercoli]

Another round of testing on getPostFormats.
The app does a 1st call to wp.getPostFormats as soon as the user switches site in the site picker, or when synching blog content in background/AsynchTask. In this 1st case the XML-RPC call made to the server is the following:

<methodCall>
    <methodName>wp.getPostFormats</methodName>
    <params>
        <param>
            <value>
                <i4>15592836</i4>
            </value>
        </param>
        <param>
            <value>
                <string>daniloercoli</string>
            </value>
        </param>
        <param>
            <value>
                <string />
            </value>
        </param>
        <param>
            <value>
                <string>show-supported</string>
            </value>
        </param>
    </params>
</methodCall>

Note that the parameter show-supported is missing from its value.
The response is the following:

<methodResponse> 
    <params> 
        <param> 
            <value> 
                <struct> 
                    <member>
                        <name>standard</name>
                        <value>
                            <string>Standard</string>
                        </value>
                    </member> 
                    <member>
                        <name>aside</name>
                        <value>
                            <string>Aside</string>
                        </value>
                    </member> 
                    <member>
                        <name>chat</name>
                        <value>
                            <string>Chiacchierare</string>
                        </value>
                    </member> 
                    <member>
                        <name>gallery</name>
                        <value>
                            <string>Gallery</string>
                        </value>
                    </member> 
                    <member>
                        <name>link</name>
                        <value>
                            <string>Link</string>
                        </value>
                    </member> 
                    <member>
                        <name>image</name>
                        <value>
                            <string>Immagine</string>
                        </value>
                    </member> 
                    <member>
                        <name>quote</name>
                        <value>
                            <string>Quote</string>
                        </value>
                    </member> 
                    <member>
                        <name>status</name>
                        <value>
                            <string>Status</string>
                        </value>
                    </member> 
                    <member>
                        <name>video</name>
                        <value>
                            <string>Video</string>
                        </value>
                    </member> 
                    <member>
                        <name>audio</name>
                        <value>
                            <string>Audio</string>
                        </value>
                    </member> 
                </struct> 
            </value> 
        </param> 
    </params> 
</methodResponse>

The server replied ignoring the show-supported parameter.

The 2nd call to wp.getPostFormats is made when the user taps on the Settings menu item.
In this case the call is correctly made to the server, including the value for the parameter show-supported.

<methodCall>
    <methodName>wp.getPostFormats</methodName>
    <params>
        <param>
            <value>
                <i4>15592836</i4>
            </value>
        </param>
        <param>
            <value>
                <string>daniloercoli</string>
            </value>
        </param>
        <param>
            <value>
                <string />
            </value>
        </param>
        <param>
            <value>
                <struct>
                    <member>
                        <name>show-supported</name>
                        <value>
                            <string>true</string>
                        </value>
                    </member>
                </struct>
            </value>
        </param>
    </params>
</methodCall>

And the response is the following:

<methodResponse> 
    <params> 
        <param> 
            <value> 
                <struct> 
                    <member>
                        <name>all</name>
                        <value>
                            <struct> 
                                <member>
                                    <name>standard</name>
                                    <value>
                                        <string>Standard</string>
                                    </value>
                                </member> 
                                <member>
                                    <name>aside</name>
                                    <value>
                                        <string>Aside</string>
                                    </value>
                                </member> 
                                <member>
                                    <name>chat</name>
                                    <value>
                                        <string>Chiacchierare</string>
                                    </value>
                                </member> 
                                <member>
                                    <name>gallery</name>
                                    <value>
                                        <string>Gallery</string>
                                    </value>
                                </member> 
                                <member>
                                    <name>link</name>
                                    <value>
                                        <string>Link</string>
                                    </value>
                                </member> 
                                <member>
                                    <name>image</name>
                                    <value>
                                        <string>Immagine</string>
                                    </value>
                                </member> 
                                <member>
                                    <name>quote</name>
                                    <value>
                                        <string>Quote</string>
                                    </value>
                                </member> 
                                <member>
                                    <name>status</name>
                                    <value>
                                        <string>Status</string>
                                    </value>
                                </member> 
                                <member>
                                    <name>video</name>
                                    <value>
                                        <string>Video</string>
                                    </value>
                                </member> 
                                <member>
                                    <name>audio</name>
                                    <value>
                                        <string>Audio</string>
                                    </value>
                                </member> 
                            </struct>
                        </value>
                    </member> 
                    <member>
                        <name>supported</name>
                        <value>
                            <array>
                                <data> 
                                    <value>
                                        <string>aside</string>
                                    </value> 
                                    <value>
                                        <string>image</string>
                                    </value> 
                                    <value>
                                        <string>video</string>
                                    </value> 
                                    <value>
                                        <string>link</string>
                                    </value> 
                                    <value>
                                        <string>quote</string>
                                    </value> 
                                    <value>
                                        <string>gallery</string>
                                    </value> 
                                    <value>
                                        <string>status</string>
                                    </value> 
                                    <value>
                                        <string>audio</string>
                                    </value> 
                                </data>
                            </array>
                        </value>
                    </member> 
                </struct> 
            </value> 
        </param> 
    </params> 
</methodResponse>

I bet we can unify the 2 calls above, and reuse the response from the first call if already there, and speed up the first setup of the site settings UI. (We already have the postFormats in the db and the call to upgrade it could be postponed in favour of other settings calls).

[kwonye]

• Self-hosted settings are still popping out with "Couldn't retrieve site info"
• Was @daniloercoli's comment addressed?

[kwonye]

self-hosted issue resolved with #3562

[tonyr59h]

Was @daniloercoli's comment addressed?

Addressed in 46eb536

[kwonye]

Manual testing all looks good!