CMM-814 hide or show taxonomies in the menu depending on the server configuration #22255

adalpari · 2025-10-02T15:59:57Z

Description

This PR implements dynamic taxonomies display in the site settings menu based on server configuration. The system fetches taxonomy information from self-hosted WordPress sites and shows only those taxonomies that are configured to appear in navigation menus.

Important note: Categories and Tags are the only supported taxonomies until we build the TaxonomyDataView. So, the current screen calls are hardcoded.

Testing instructions

Log into a WP.com site
Go to "Site Settings"

Verify you see "Categories" and "Tags"

Log into a self-hosted site using the XML-RPC flow
Go to "Site Settings"

Verify you DON'T see "Categories" and "Tags"

Set up Applcation Password for the site

Verify you DO see "Categories" and "Tags"

Screen.Recording.2025-10-02.at.18.15.57.mov

dangermattic · 2025-10-02T16:01:04Z

	2 Warnings
⚠️	`strings.xml` files should only be updated on release branches, when the translations are downloaded by our automation.
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

Copilot

Pull Request Overview

This PR implements dynamic taxonomies display in the site settings menu based on server configuration. The system fetches taxonomy information from self-hosted WordPress sites and shows only those taxonomies that are configured to appear in navigation menus.

Adds a new ViewModel to fetch and filter taxonomies from the WordPress API
Updates the site settings UI to dynamically display taxonomy preferences based on server response
Removes hardcoded writing section preferences in favor of dynamic taxonomy handling

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
strings.xml	Adds "Taxonomies" title string for the new preference section
key_strings.xml	Adds preference key for taxonomies section
TaxonomiesNavMenuViewModel.kt	New ViewModel that fetches taxonomies and filters by nav menu visibility
SiteSettingsFragment.java	Integrates taxonomy fetching and dynamically creates preference UI
ViewModelModule.java	Registers the new ViewModel for dependency injection

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

WordPress/src/main/java/org/wordpress/android/ui/prefs/SiteSettingsFragment.java

wpmobilebot · 2025-10-02T16:22:17Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22255-b3e623b
	Commit	`b3e623b`
	Direct Download	`jetpack-prototype-build-pr22255-b3e623b.apk`

Note: Google Login is not supported on these builds.

WordPress/src/main/java/org/wordpress/android/ui/prefs/SiteSettingsFragment.java


    private BloggingRemindersViewModel mBloggingRemindersViewModel;

+    private TaxonomiesNavMenuViewModel mTaxonomiesNavMenuViewModel;


wpmobilebot · 2025-10-02T16:30:53Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22255-b3e623b
	Commit	`b3e623b`
	Direct Download	`wordpress-prototype-build-pr22255-b3e623b.apk`

Note: Google Login is not supported on these builds.

codecov · 2025-10-03T09:20:23Z

Codecov Report

❌ Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.93%. Comparing base (33d22f3) to head (b3e623b).

Files with missing lines	Patch %	Lines
.../ui/prefs/taxonomies/TaxonomiesNavMenuViewModel.kt	92.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk   #22255      +/-   ##
==========================================
+ Coverage   39.91%   39.93%   +0.01%     
==========================================
  Files        2165     2166       +1     
  Lines      102511   102536      +25     
  Branches    14771    14774       +3     
==========================================
+ Hits        40922    40945      +23     
- Misses      58122    58123       +1     
- Partials     3467     3468       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dcalhoun

Code looks good. Test plan succeeded for me. That said...

This PR implements dynamic taxonomies display in the site settings menu based on server configuration. The system fetches taxonomy information from self-hosted WordPress sites and shows only those taxonomies that are configured to appear in navigation menus.

Why do we toggle visibility in the app based upon show_in_nav_menus? My perception is that this property is used for controlling taxonomy visibility when creating WordPress menus rendered on a site's front end. Is my understanding incorrect?

An aside: this currently includes changes from #22252 due to the stacked branch and recent merge. Unsure if it is worth rebase or not.

…-menu-depending-on-the-server-configuration

adalpari · 2025-10-03T13:20:34Z

An aside: this currently includes changes from #22252 due to the stacked branch and recent merge. Unsure if it is worth rebase or not.

My bad because of wrong targeting. Fixed!

sonarqubecloud · 2025-10-03T13:22:52Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

adalpari · 2025-10-03T13:33:55Z

Why do we toggle visibility in the app based upon show_in_nav_menus? My perception is that this property is used for controlling taxonomy visibility when creating WordPress menus rendered on a site's front end. Is my understanding incorrect?

If I understood it correctly, we don't want to show all the given taxonomies if the visibility setting is set to false. I see now that I might be using showAdminColumn instead of showInNavMenus?

Related question to @jkmassel too:

On https://cpt.wpmt.co/wp-admin/ I don't see Categories and Tags, but the response when requesting taxonomies doesn't contain any false value on any of those fields. Neither showAdminColumn nor showInNavMenus

jkmassel · 2025-10-03T14:47:24Z

Why do we toggle visibility in the app based upon show_in_nav_menus? My perception is that this property is used for controlling taxonomy visibility when creating WordPress menus rendered on a site's front end. Is my understanding incorrect?

@adalpari is correct – not all taxonomies are user-facing, and custom-registered ones might deliberately not want to be.

We want to match the behaviour of wp-admin as much as possible, which this will do.

dcalhoun · 2025-10-03T15:48:30Z

Thank you for elaborating.

I understand and agree with the desired outcome. However, my understanding from register_taxonomy() documentation is that show_in_menu and show_ui control taxonomy visibility in the WP Admin menu (sidebar); not show_in_nav_menus, which controls Appearance → Menus specifically. Am I mistaken?

adalpari · 2025-10-03T15:57:37Z

Thank you for elaborating.

I understand and agree with the desired outcome. However, my understanding from register_taxonomy() documentation is that show_in_menu and show_ui control taxonomy visibility in the WP Admin menu (sidebar); not show_in_nav_menus, which controls Appearance → Menus specifically. Am I mistaken?

I think you are right. I'll go with those ones.
Thanks!

adalpari added 17 commits October 1, 2025 12:29

Updating library

f00d50e

Porting the terms fetching

dc07310

Porting create

9358243

Porting delete term

9bb9e35

porting update term

5e62ed7

Update term fix

726a4d3

Creating the new isHierarchical cocal field

3a0639b

Parent fix

6bce343

Fixing tests

c39d8fb

detekt

630a7b1

Minor fix

10b8ab2

Fixing tests

03b8a91

Adding the taxonomies menu view model

7347ee2

Adding show mechanism

1a3a864

Showing taxoniomies

025c3ea

Adding a LiveData

a7de2e3

Call categories and tags screens

d37d8a2

adalpari requested a review from Copilot October 2, 2025 16:00

adalpari added the [Type] Task label Oct 2, 2025

Copilot AI reviewed Oct 2, 2025

View reviewed changes

detekt and style

6f2bcd1

github-advanced-security bot found potential problems Oct 2, 2025

View reviewed changes

Adding tests

bbdc79f

adalpari marked this pull request as ready for review October 3, 2025 09:00

adalpari requested review from dcalhoun, oguzkocer and jkmassel October 3, 2025 09:19

Base automatically changed from task/CMM-808-port-categories-and-tags-to-the-new-generic-wordpress-rs-endpoint to trunk October 3, 2025 12:18

adalpari requested a review from a team as a code owner October 3, 2025 12:18

dcalhoun reviewed Oct 3, 2025

View reviewed changes

Merge branch 'trunk' into task/cmm-814-hide-or-show-taxonomies-in-the…

b3e623b

…-menu-depending-on-the-server-configuration

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CMM-814 hide or show taxonomies in the menu depending on the server configuration #22255

CMM-814 hide or show taxonomies in the menu depending on the server configuration #22255

Uh oh!

adalpari commented Oct 2, 2025 •

edited

Loading

Uh oh!

dangermattic commented Oct 2, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wpmobilebot commented Oct 2, 2025 •

edited

Loading

Uh oh!

Check notice

wpmobilebot commented Oct 2, 2025 •

edited

Loading

Uh oh!

codecov bot commented Oct 3, 2025 •

edited

Loading

Uh oh!

dcalhoun left a comment

Uh oh!

adalpari commented Oct 3, 2025

Uh oh!

sonarqubecloud bot commented Oct 3, 2025

Uh oh!

adalpari commented Oct 3, 2025 •

edited

Loading

Uh oh!

jkmassel commented Oct 3, 2025

Uh oh!

dcalhoun commented Oct 3, 2025

Uh oh!

adalpari commented Oct 3, 2025 •

edited

Loading

Uh oh!

Uh oh!


		private BloggingRemindersViewModel mBloggingRemindersViewModel;

		private TaxonomiesNavMenuViewModel mTaxonomiesNavMenuViewModel;

CMM-814 hide or show taxonomies in the menu depending on the server configuration #22255

Are you sure you want to change the base?

CMM-814 hide or show taxonomies in the menu depending on the server configuration #22255

Uh oh!

Conversation

adalpari commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Uh oh!

dangermattic commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wpmobilebot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Check notice

wpmobilebot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dcalhoun left a comment

Choose a reason for hiding this comment

Uh oh!

adalpari commented Oct 3, 2025

Uh oh!

sonarqubecloud bot commented Oct 3, 2025

Quality Gate passed

Uh oh!

adalpari commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkmassel commented Oct 3, 2025

Uh oh!

dcalhoun commented Oct 3, 2025

Uh oh!

adalpari commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

adalpari commented Oct 2, 2025 •

edited

Loading

dangermattic commented Oct 2, 2025 •

edited

Loading

wpmobilebot commented Oct 2, 2025 •

edited

Loading

wpmobilebot commented Oct 2, 2025 •

edited

Loading

codecov bot commented Oct 3, 2025 •

edited

Loading

adalpari commented Oct 3, 2025 •

edited

Loading

adalpari commented Oct 3, 2025 •

edited

Loading