CMM-808 port categories and tags to the new generic wordpress-rs API #22252

adalpari · 2025-10-01T12:28:14Z

Description

This PR updates the taxonomy CRUD implementation to use the new generic WordPress-RS API instead of the previous category and tag-specific endpoints. So, from now on, all terms will be used the same way by just specifying the taxonomy name.

Testing instructions

Log into a self-hosted site USING Application Password credentials
Go to "Site Settings"
Smoke test "Categories" and "Tags"

Verify Categories CRUD work as expected
Verify Tags CRUD work as expected

Screen.Recording.2025-10-01.at.14.41.07.mov

Screen.Recording.2025-10-01.at.14.40.33.mov

Copilot

Pull Request Overview

This PR updates the taxonomy API implementation to use the new generic wordpress-rs API instead of the previous category and tag-specific endpoints. The main purpose is to modernize the codebase by consolidating separate category and tag handling into a unified terms API approach.

Replaces separate category and tag API classes with unified term endpoints using TermEndpointType
Adds isHierarchical field to TermModel to distinguish between hierarchical (categories) and flat (tags) taxonomies
Updates all related test files and usage sites to accommodate the new API structure

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`TaxonomyRsApiRestClient.kt`	Complete refactor to use unified terms API instead of separate category/tag endpoints
`TermModel.java`	Added `isHierarchical` boolean field and updated constructor
`WellSqlConfig.kt`	Database migration to add `IS_HIERARCHICAL` column to `TermModel`
`TaxonomyRsApiRestClientTest.kt`	Updated tests to use new unified API and added `isHierarchical` field
`TaxonomyTestUtils.java`	Updated test helper to include `isHierarchical` parameter
Various other files	Updated to accommodate new API signature and field additions

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

...main/java/org/wordpress/android/fluxc/network/rest/wpapi/taxonomy/TaxonomyRsApiRestClient.kt

libs/fluxc/src/main/java/org/wordpress/android/fluxc/persistence/WellSqlConfig.kt

dangermattic · 2025-10-01T12:30:10Z

	2 Warnings
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

wpmobilebot · 2025-10-01T12:37:40Z

Project dependencies changes

list

! Upgraded Dependencies
net.java.dev.jna:jna:5.18.0, (changed from 5.17.0)
rs.wordpress.api:android:trunk-d0c9eebab77e8701810077ac1fba7d39ef8d121f, (changed from trunk-f4e2450ca5545a4909cb08273f37a7f694244921)
rs.wordpress.api:kotlin:trunk-d0c9eebab77e8701810077ac1fba7d39ef8d121f, (changed from trunk-f4e2450ca5545a4909cb08273f37a7f694244921)

tree

 +--- project :libs:fluxc
-|    \--- rs.wordpress.api:android:trunk-f4e2450ca5545a4909cb08273f37a7f694244921
-|         +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-|         +--- com.squareup.okhttp3:okhttp-tls:4.12.0
-|         |    +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-|         |    +--- com.squareup.okio:okio:3.6.0 -> 3.9.0 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.24 (*)
-|         +--- net.java.dev.jna:jna:5.17.0
-|         +--- rs.wordpress.api:kotlin:trunk-f4e2450ca5545a4909cb08273f37a7f694244921
-|         |    +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-|         |    +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
-|         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.10 (*)
-|         \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.10 (*)
+|    \--- rs.wordpress.api:android:trunk-d0c9eebab77e8701810077ac1fba7d39ef8d121f
+|         +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+|         +--- com.squareup.okhttp3:okhttp-tls:4.12.0
+|         |    +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+|         |    +--- com.squareup.okio:okio:3.6.0 -> 3.9.0 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.24 (*)
+|         +--- net.java.dev.jna:jna:5.18.0
+|         +--- rs.wordpress.api:kotlin:trunk-d0c9eebab77e8701810077ac1fba7d39ef8d121f
+|         |    +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+|         |    +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
+|         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.10 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.10 (*)
-+--- rs.wordpress.api:android:trunk-f4e2450ca5545a4909cb08273f37a7f694244921 (*)
++--- rs.wordpress.api:android:trunk-d0c9eebab77e8701810077ac1fba7d39ef8d121f (*)
 \--- com.automattic:encryptedlogging:1.1.0
-     \--- net.java.dev.jna:jna:5.17.0
+     \--- net.java.dev.jna:jna:5.17.0 -> 5.18.0

wpmobilebot · 2025-10-01T12:51:31Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22252-03b8a91
	Commit	`03b8a91`
	Direct Download	`wordpress-prototype-build-pr22252-03b8a91.apk`

Note: Google Login is not supported on these builds.

sonarqubecloud · 2025-10-01T12:54:18Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

wpmobilebot · 2025-10-01T13:14:48Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22252-03b8a91
	Commit	`03b8a91`
	Direct Download	`jetpack-prototype-build-pr22252-03b8a91.apk`

Note: Google Login is not supported on these builds.

codecov · 2025-10-01T13:14:57Z

Codecov Report

❌ Patch coverage is 78.10219% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.91%. Comparing base (bbcdfad) to head (03b8a91).
⚠️ Report is 4 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...ork/rest/wpapi/taxonomy/TaxonomyRsApiRestClient.kt	81.10%	16 Missing and 8 partials ⚠️
...ordpress/android/ui/selfhostedusers/SampleUsers.kt	0.00%	3 Missing ⚠️
.../wordpress/android/ui/posts/EditCategoryUseCase.kt	0.00%	1 Missing ⚠️
...rdpress/android/fluxc/persistence/WellSqlConfig.kt	50.00%	1 Missing ⚠️
...g/wordpress/android/fluxc/store/TaxonomyStore.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk   #22252      +/-   ##
==========================================
- Coverage   39.98%   39.91%   -0.07%     
==========================================
  Files        2165     2165              
  Lines      102627   102511     -116     
  Branches    14766    14771       +5     
==========================================
- Hits        41034    40922     -112     
+ Misses      58130    58122       -8     
- Partials     3463     3467       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dcalhoun

Looks good. 🧹 Changes tested well for me.

I noted one issue, but it also occurs in the production release. Attempting to modify a term without a network connection causes the app to enter an infinite "Saving" state. Ideally, we handle the failed request with an error message and potentially retry when the network connection returns. Currently, the app remains in the saving state even after regaining a network connection. The user is unable to exit the screen and must quit the app.

Screen recording

Screen_Recording_20251003_074824_Jetpack.Pre-Alpha.mp4

adalpari · 2025-10-03T12:17:50Z

Looks good. 🧹 Changes tested well for me.

I noted one issue, but it also occurs in the production release. Attempting to modify a term without a network connection causes the app to enter an infinite "Saving" state. Ideally, we handle the failed request with an error message and potentially retry when the network connection returns. Currently, the app remains in the saving state even after regaining a network connection. The user is unable to exit the screen and must quit the app.

Thank you for the heads up. I experimented something similar, but I think it's better to work on it as a separate bug since it's not related to the migration.

adalpari added 10 commits October 1, 2025 12:29

Updating library

f00d50e

Porting the terms fetching

dc07310

Porting create

9358243

Porting delete term

9bb9e35

porting update term

5e62ed7

Update term fix

726a4d3

Creating the new isHierarchical cocal field

3a0639b

Parent fix

6bce343

Fixing tests

c39d8fb

detekt

630a7b1

adalpari requested a review from Copilot October 1, 2025 12:28

Copilot AI reviewed Oct 1, 2025

View reviewed changes

...main/java/org/wordpress/android/fluxc/network/rest/wpapi/taxonomy/TaxonomyRsApiRestClient.kt Outdated Show resolved Hide resolved

libs/fluxc/src/main/java/org/wordpress/android/fluxc/persistence/WellSqlConfig.kt Show resolved Hide resolved

Minor fix

10b8ab2

Fixing tests

03b8a91

adalpari marked this pull request as ready for review October 1, 2025 13:19

adalpari requested a review from a team as a code owner October 1, 2025 13:19

adalpari requested a review from jkmassel October 1, 2025 13:20

adalpari added the [Type] Task label Oct 1, 2025

adalpari requested review from dcalhoun and oguzkocer October 3, 2025 09:17

dcalhoun approved these changes Oct 3, 2025

View reviewed changes

adalpari merged commit 33d22f3 into trunk Oct 3, 2025
28 checks passed

adalpari deleted the task/CMM-808-port-categories-and-tags-to-the-new-generic-wordpress-rs-endpoint branch October 3, 2025 12:18

dcalhoun mentioned this pull request Oct 3, 2025

CMM-814 hide or show taxonomies in the menu depending on the server configuration #22255

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CMM-808 port categories and tags to the new generic wordpress-rs API #22252

CMM-808 port categories and tags to the new generic wordpress-rs API #22252

Uh oh!

adalpari commented Oct 1, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

dangermattic commented Oct 1, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Oct 1, 2025

Uh oh!

wpmobilebot commented Oct 1, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Oct 1, 2025

Uh oh!

wpmobilebot commented Oct 1, 2025

Uh oh!

codecov bot commented Oct 1, 2025 •

edited

Loading

Uh oh!

dcalhoun left a comment

Uh oh!

adalpari commented Oct 3, 2025

Uh oh!

Uh oh!

Uh oh!

CMM-808 port categories and tags to the new generic wordpress-rs API #22252

CMM-808 port categories and tags to the new generic wordpress-rs API #22252

Uh oh!

Conversation

adalpari commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

dangermattic commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Oct 1, 2025

Project dependencies changes

Uh oh!

wpmobilebot commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Oct 1, 2025

Quality Gate passed

Uh oh!

wpmobilebot commented Oct 1, 2025

Uh oh!

codecov bot commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dcalhoun left a comment

Choose a reason for hiding this comment

Uh oh!

adalpari commented Oct 3, 2025

Uh oh!

Uh oh!

Uh oh!

adalpari commented Oct 1, 2025 •

edited

Loading

dangermattic commented Oct 1, 2025 •

edited

Loading

wpmobilebot commented Oct 1, 2025 •

edited

Loading

codecov bot commented Oct 1, 2025 •

edited

Loading